Update bunch of obsolete autoconf macros #8392

cniethammer · 2021-01-19T21:58:45Z

Updated macros as follows (all replacements available in autoconf 2.60):
AC_HELP_STRING --> AS_HELP_STRING
AC_ERROR --> AC_MSG_ERROR
AC_VERBOSE --> AC_MSG_NOTICE
AC_FD_CC --> AS_MESSAGE_LOG_FD
AC_CONFIG_HEADER --> AC_CONFIG_HEADERS

Signed-off-by: Christoph Niethammer niethammer@hlrs.de

rhc54 · 2021-01-20T00:51:09Z

EC2 failure

bot:aws:retest

rhc54 · 2021-01-20T00:51:52Z

@cniethammer Nice job! I appreciate you identifying the required changes as that will help a great deal in updating PMIx and PRRTE.

rhc54 · 2021-01-20T04:03:37Z

@cniethammer I'm following your guide and trying to update PMIx, yet I'm getting a lot of warnings when running autogen.pl with autoconf 2.70:

configure.ac:251: warning: The macro `AC_TRY_LINK' is obsolete.
configure.ac:251: You should run autoupdate.

configure.ac:251: warning: The macro `AC_TRY_COMPILE' is obsolete.
configure.ac:251: You should run autoupdate.

configure.ac:251: warning: The macro `AC_PROG_NM' is obsolete.
configure.ac:251: You should run autoupdate.

configure.ac:251: warning: The macro `_AC_COMPUTE_INT' is obsolete.
configure.ac:251: You should run autoupdate.

configure.ac:251: warning: The macro `AC_HEADER_STDC' is obsolete.
configure.ac:251: You should run autoupdate.

configure.ac:224: warning: AC_PROG_LEX without either yywrap or noyywrap is obsolete
./lib/autoconf/programs.m4:740: _AC_PROG_LEX is expanded from...
./lib/autoconf/programs.m4:714: AC_PROG_LEX is expanded from...

Since we copy almost all of our m4 from OMPI, I checked and those macros are still in OMPI master. Are you seeing the same warnings? Note that autogen.pl completed successfully even with all those warnings.

rhc54 · 2021-01-20T08:12:44Z

Take a gander at openpmix/openpmix#2029 where I have started to deal with all those warnings. I believe we'll need to do the same on OMPI.

cniethammer · 2021-01-20T09:39:47Z

@rhc54 yes I see also a lot of left stuff as I did not fix all warnings: (a) some of these are not straight forward, e.g., the C99 detection part, and (b) fixes are dependent on the autoconf version. So far I only used alternatives compatible with 2.60, which I found to be the required min version in ompi's configure.ac.

rhc54 · 2021-01-20T13:50:42Z

Yeah, I think that 2.60 is too low - this 2.70 release is going to force us to raise that minimum version. Not sure how high we have to go to find fully compatible solutions. I'm using the ones available in 2.69 for now as that has been released for many years now and seems pretty available, and I believe its changes go back a little further (something like 2.67?). We should raise this issue at the next telecon.

config/ompi_configure_options.m4

gpaulsen · 2021-03-01T21:01:27Z

@cniethammer, could you please rebase this, and try again?

Great to get this in, and then talk about how much effort the autoconf 2.7 is going to be, and if we need it for v5.0.

awlauria · 2021-03-01T21:20:40Z

It looks like autoconf v2.7 just came out in Dec 2020 based on these dates:
http://ftp.gnu.org/gnu/autoconf/

Since it's so new I'm of the opinion that this is not needed for v5.0, unless someone really needs the latest and greatest. FWIW RHEL 8 is still on autoconf 2.69, and I can't see them updating until at earliest RHEL 9 (but that is just a guess). Are there any distros picking up 2.7 at this time?

awlauria · 2021-03-01T22:53:46Z

Checking some distros:

Ubuntu 16.04/18.04/20.4/20.10: 2.69
RHEL 7.7/8.2: 2.69
openSUSE 15.2/Tumbleweed: 2.69
Amazon Linux 1: 2.69
Amazon Linux 2: can't find data

rhc54 · 2021-03-09T22:40:59Z

@cniethammer Did you have any luck finding a replacement for AC_PROG_NM? I'm striking out. I simply remo,ved it and it seems to work just fine without it.

Anyone know if we really need this?

bwbarrett · 2021-03-10T00:09:50Z

We do still need $NM defined, because we use it in the assembly configure code. However, it looks Libtool defines it these days anyway, and it's an alias for LT_PATH_NM. So I think we can just call LT_PATH_NM and be good to go.

rhc54 · 2021-03-10T01:02:54Z

@jsquyres suggested on Slack AC_PATH_PROG([NM], [nm]) - would that suffice?

bwbarrett · 2021-03-10T01:05:04Z

I think LT_PROG_NM should work. Does it not? It actually checks more than a simple AC_PATH_PROG, in that it verifies that the nm found actually speaks BSD (which we rely on).

rhc54 · 2021-03-10T01:18:49Z

Haven't tried it - will do so and report back.

rhc54 · 2021-03-10T01:26:37Z

I've confirmed that LT_PATH_NM works fine (@bwbarrett provided the corrected name).

cniethammer · 2021-03-10T11:03:49Z

@rhc54 I included the fix replacing AC_PROG_NM with LT_PATH_NM as suggested
Works for me on my system with autoconf 2.71 and libtool 2.4.6.42

jsquyres · 2021-03-10T14:01:39Z

I didn't look deep enough to find LT_PATH_NM; if that exists, it's probably a better solution.

It looks like we AC_REQUIRE([AC_PROG_NM]) in a few places in OMPI -- that should probably be changed to AC_REQUIRE([LT_PATH_NM]) to make sure $NM is set when we need it.

cniethammer · 2021-03-10T14:38:55Z

@jsquyres There are no other AC_PROG_NM in OMPI as far as I saw - all I found was in 3rd-party / openmpix and prrte configure.

jsquyres · 2021-03-10T14:44:34Z

@jsquyres There are no other AC_PROG_NM in OMPI as far as I saw - all I found was in 3rd-party / openmpix and prrte configure.

https://github.com/open-mpi/ompi/blob/master/config/ompi_fortran_find_ext_symbol_convention.m4#L26
https://github.com/open-mpi/ompi/blob/master/config/opal_config_asm.m4#L542
https://github.com/open-mpi/ompi/blob/master/config/opal_config_asm.m4#L703

rhc54 · 2021-03-10T14:59:48Z

Just as an FYI: in searching for solutions to some of these obsolete warnings, I have found tons of projects that are doing the update to support v2.70. I think this is something we are really just going to have to complete.

cniethammer · 2021-03-10T16:20:11Z

@jsquyres There are no other AC_PROG_NM in OMPI as far as I saw - all I found was in 3rd-party / openmpix and prrte configure.

https://github.com/open-mpi/ompi/blob/master/config/ompi_fortran_find_ext_symbol_convention.m4#L26
https://github.com/open-mpi/ompi/blob/master/config/opal_config_asm.m4#L542
https://github.com/open-mpi/ompi/blob/master/config/opal_config_asm.m4#L703

That's covered by my last commit in this PR from this morning - d52673e

jsquyres · 2021-03-10T16:26:37Z

That's covered by my last commit in this PR from this morning - d52673e

I admittedly didn't look at your patches from this morning; I was just replying to your text. 😄

It looks like the treematch merge made a conflict with this PR. ☹️ Can you fix?

Updated macros as follows (all replacements available in autoconf 2.60): AC_HELP_STRING --> AS_HELP_STRING AC_ERROR --> AC_MSG_ERROR AC_VERBOSE --> AC_MSG_NOTICE AC_FD_CC --> AS_MESSAGE_LOG_FD AC_CONFIG_HEADER --> AC_CONFIG_HEADERS Signed-off-by: Christoph Niethammer <niethammer@hlrs.de>

Updated libtool related macros as follows: AM_ENABLE_SHARED --> AC_ENABLE_SHARED AM_DISABLE_STATIC --> AC_DISABLE_STATIC Note: libtool renamed AM_* macros to AC_* in 1999 Signed-off-by: Christoph Niethammer <niethammer@hlrs.de>

…ssing Signed-off-by: Christoph Niethammer <niethammer@hlrs.de>

With autoconf 2.70 AC_PROG_CC now enables C2011 by default and will handle C99 and C89. Signed-off-by: Christoph Niethammer <niethammer@hlrs.de>

AC_PROG_NM --> LT_PATH_NM Signed-off-by: Christoph Niethammer <niethammer@hlrs.de>

jsquyres · 2021-03-10T20:31:22Z

I think we all agree; I'll take the liberty of merging this in.

cniethammer requested a review from jsquyres January 19, 2021 21:58

cniethammer mentioned this pull request Jan 19, 2021

Configure errors with autoconf 2.70 #8377

Closed

cniethammer added Target: main Target: v4.0.x Target: v4.1.x and removed Target: v4.0.x Target: v4.1.x labels Jan 19, 2021

bwbarrett approved these changes Jan 20, 2021

View reviewed changes

config/ompi_configure_options.m4 Outdated Show resolved Hide resolved

cniethammer force-pushed the autoconf-2.70-warning-fixes branch 2 times, most recently from 34db19c to 8860e57 Compare January 21, 2021 19:19

cniethammer force-pushed the autoconf-2.70-warning-fixes branch from 8860e57 to d52673e Compare March 10, 2021 10:58

rhc54 mentioned this pull request Mar 10, 2021

Update configure to support Autoconf v2.70 openpmix/prrte#815

Merged

cniethammer added 5 commits March 10, 2021 17:51

Update obsolete libtool related autoconf macros

8f0f87c

Updated libtool related macros as follows: AM_ENABLE_SHARED --> AC_ENABLE_SHARED AM_DISABLE_STATIC --> AC_DISABLE_STATIC Note: libtool renamed AM_* macros to AC_* in 1999 Signed-off-by: Christoph Niethammer <niethammer@hlrs.de>

Add propper quoting for AC_ARG_ENABLE and AC_ARG_WITH macros where mi…

b84c60e

…ssing Signed-off-by: Christoph Niethammer <niethammer@hlrs.de>

Ignore AC_PROG_CC_C99 obsolete from autoconf 2.70 on

2157431

With autoconf 2.70 AC_PROG_CC now enables C2011 by default and will handle C99 and C89. Signed-off-by: Christoph Niethammer <niethammer@hlrs.de>

Update obsolete autoconf macro

a988a8f

AC_PROG_NM --> LT_PATH_NM Signed-off-by: Christoph Niethammer <niethammer@hlrs.de>

cniethammer force-pushed the autoconf-2.70-warning-fixes branch from d52673e to a988a8f Compare March 10, 2021 18:48

bwbarrett approved these changes Mar 10, 2021

View reviewed changes

rhc54 approved these changes Mar 10, 2021

View reviewed changes

jsquyres approved these changes Mar 10, 2021

View reviewed changes

jsquyres merged commit d91e646 into open-mpi:master Mar 10, 2021

cniethammer deleted the autoconf-2.70-warning-fixes branch March 10, 2021 22:29

Update bunch of obsolete autoconf macros #8392

Update bunch of obsolete autoconf macros #8392

Uh oh!

Conversation

cniethammer commented Jan 19, 2021

Uh oh!

rhc54 commented Jan 20, 2021

Uh oh!

rhc54 commented Jan 20, 2021

Uh oh!

rhc54 commented Jan 20, 2021

Uh oh!

rhc54 commented Jan 20, 2021

Uh oh!

cniethammer commented Jan 20, 2021

Uh oh!

rhc54 commented Jan 20, 2021

Uh oh!

Uh oh!

gpaulsen commented Mar 1, 2021

Uh oh!

awlauria commented Mar 1, 2021

Uh oh!

awlauria commented Mar 1, 2021

Uh oh!

rhc54 commented Mar 9, 2021

Uh oh!

bwbarrett commented Mar 10, 2021

Uh oh!

rhc54 commented Mar 10, 2021

Uh oh!

bwbarrett commented Mar 10, 2021

Uh oh!

rhc54 commented Mar 10, 2021

Uh oh!

rhc54 commented Mar 10, 2021

Uh oh!

cniethammer commented Mar 10, 2021

Uh oh!

jsquyres commented Mar 10, 2021

Uh oh!

cniethammer commented Mar 10, 2021

Uh oh!

jsquyres commented Mar 10, 2021

Uh oh!

rhc54 commented Mar 10, 2021

Uh oh!

cniethammer commented Mar 10, 2021

Uh oh!

jsquyres commented Mar 10, 2021

Uh oh!

jsquyres commented Mar 10, 2021

Uh oh!

Uh oh!