Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ucx: disable version 1.8 #8511

Merged
merged 1 commit into from
Feb 23, 2021
Merged

ucx: disable version 1.8 #8511

merged 1 commit into from
Feb 23, 2021

Conversation

yosefe
Copy link
Contributor

@yosefe yosefe commented Feb 22, 2021 •
edited
Loading

jsquyres
jsquyres reviewed Feb 22, 2021
View reviewed changes
Copy link
Member

@jsquyres jsquyres left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Just one minor autoconf output style issue.

Is only UCX 1.8.x bad? Or is it all versions <v1.9.0?

config/ompi_check_ucx.m4 Outdated Show resolved Hide resolved
@ibm-ompi
Copy link

The IBM CI (GNU/Scale) build failed! Please review the log, linked below.

Gist: https://gist.github.com/58ec73a78b2cb1901c47d01c3ce44aac

@yosefe
Copy link
Contributor Author

yosefe commented Feb 22, 2021

Thanks! Just one minor autoconf output style issue.

Is only UCX 1.8.x bad? Or is it all versions <v1.9.0?

We checked, only v1.8.x is affected.

@ibm-ompi
Copy link

The IBM CI (PGI) build failed! Please review the log, linked below.

Gist: https://gist.github.com/4d3afc96ffc0d0692c94a5362db78d1d

@ibm-ompi
Copy link

The IBM CI (XL) build failed! Please review the log, linked below.

Gist: https://gist.github.com/06e904307fd76f5d7bdf693dbe5e9b25

@jsquyres
Copy link
Member

Looks like all those CI's are failing because they're using UCX 1.8. 😆

@yosefe yosefe force-pushed the topic/ucx-disable-version-1-8 branch from d9eb28e to ee90f1f Compare February 23, 2021 00:00
@yosefe
Copy link
Contributor Author

yosefe commented Feb 23, 2021 •
edited
Loading

This is how it looks with e2231e6 and --with-ucx=/tmp/ucx-v1.8/install:

--- MCA component common:ucx (m4 configuration macro)
checking for MCA component common:ucx compile mode... dso
checking --with-ucx value... sanity check ok (/tmp/ucx-v1.8/install)
checking --with-ucx-libdir value... simple ok (unspecified value)
checking ucp/api/ucp.h usability... yes
checking ucp/api/ucp.h presence... yes
checking for ucp/api/ucp.h... yes
checking for library containing ucp_cleanup... -lucp
checking if libucp requires libnl v1 or v3... configure: WARNING: Could not link a simple program with lib ucp
checking for UCX version compatibility... yes
checking UCX version... bad (1.8.x)
configure: error: UCX support requested but not found.  Aborting

No --with-ucx, but just adding ucx-v1.8 to library/include paths:

--- MCA component common:ucx (m4 configuration macro)
checking for MCA component common:ucx compile mode... dso
checking --with-ucx value... simple ok (unspecified value)
checking --with-ucx-libdir value... simple ok (unspecified value)
checking for ucx... yes
checking ucp/api/ucp.h usability... yes
checking ucp/api/ucp.h presence... yes
checking for ucp/api/ucp.h... yes
checking for library containing ucp_cleanup... -lucp
checking if libucp requires libnl v1 or v3... configure: WARNING: Could not link a simple program with lib ucp
checking for UCX version compatibility... yes
checking UCX version... bad (1.8.x)
checking if MCA component common:ucx can compile... no
...
Transports
-----------------------
Cisco usNIC: no
Cray uGNI (Gemini/Aries): no
Intel Omnipath (PSM2): no
Open UCX: no
OpenFabrics OFI Libfabric: no
Portals4: no
...

@yosefe yosefe force-pushed the topic/ucx-disable-version-1-8 branch from ee90f1f to e2231e6 Compare February 23, 2021 00:28
@yosefe
Copy link
Contributor Author

yosefe commented Feb 23, 2021

@jsquyres your comments were applied, do we want to wait until CI is fixed?

jsquyres
jsquyres reviewed Feb 23, 2021
View reviewed changes
ompi/mca/pml/ucx/pml_ucx.c Outdated Show resolved Hide resolved
config/ompi_check_ucx.m4 Show resolved Hide resolved
@yosefe @jsquyres
ucx: disable version 1.8
b49cbf4 
Signed-off-by: Yossi Itigin <yosefe@mellanox.com>
@jsquyres jsquyres force-pushed the topic/ucx-disable-version-1-8 branch from 9210b4e to b49cbf4 Compare February 23, 2021 19:22
jsquyres
jsquyres approved these changes Feb 23, 2021
View reviewed changes
Copy link
Member

@jsquyres jsquyres left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I took the liberty of squashing both commits down into a single commit.

@yosefe You might want to update your .gitconfig for your new email address for future commits. 😄

@jsquyres jsquyres assigned jsquyres and unassigned jsquyres Feb 23, 2021
@jsquyres jsquyres merged commit 7343386 into open-mpi:master Feb 23, 2021
@jsquyres
Copy link
Member

@yosefe Can you PR this to v4.0.x and v4.1.x?

Thanks!

@yosefe yosefe deleted the topic/ucx-disable-version-1-8 branch February 23, 2021 21:16
This was referenced Feb 23, 2021
Merged
Merged
@haampie haampie mentioned this pull request Apr 8, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsquyres jsquyres jsquyres approved these changes

Assignees
No one assigned
Labels
bug Target: main Target: v4.0.x Target: v4.1.x Target: v5.0.x
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Processes returns wrong results on OpenMPI 4.0.4 unless $OMPI_MCA_pml is set to "^ucx"
3 participants
@yosefe @ibm-ompi @jsquyres