Fix coredump for unaligned atomics. #8599
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Opened as an alternative to #8574 |
bosilca
approved these changes
Mar 12, 2021
awlauria
force-pushed
the
atomics_core_2
branch
2 times, most recently
from
c0754f3 to
573352b
Compare
Signed-off-by: Austen Lauria <awlauria@us.ibm.com>
Choose the read-modify-write path over the atomics path when the address isn't aligned. Signed-off-by: Austen Lauria <awlauria@us.ibm.com>
It's a common function between rdma and ucx, put it somewhere both can access it. Signed-off-by: Austen Lauria <awlauria@us.ibm.com>
Signed-off-by: Austen Lauria <awlauria@us.ibm.com>
awlauria
force-pushed
the
atomics_core_2
branch
from
573352b to
4e34bf0
Compare
|
I'm not sure I understand how this deals with misaligned atomics at all levels. We might still end up doing misaligned CPU atomics in |
|
The BTL atomics should never be used with unaligned values. If we enforce that requirement this is sufficient since we have no other path that would attempt it. |
|
@devreal the test where I found this, c_reqops.c, passes with this change as well as #8574. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.