autoconf: fix --enable-mca-dso: correct two bugs that broke it #8799
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix bug introduced in 000f7e8. AS_VAR_COPY(dest, source) interprets the 'source' argument as a variable name. So, before this patch, the value was not '1', but '$1', which evaluated to garbage and broke the --enable-mca-dso argument. Signed-off-by: Alexei Colin <acolin@isi.edu>
Typo introduced in 000f7e8. Signed-off-by: Alexei Colin <acolin@isi.edu>
|
Can one of the admins verify this patch? |
acolinisi
commented
Apr 11, 2021
| @@ -149,7 +149,7 @@ AC_DEFUN([OPAL_MCA],[ | |||
| AC_MSG_ERROR([*** The enable-mca-direct flag requires a | |||
| *** list of type-component pairs. Invalid input detected.]) | |||
| else | |||
| AS_VAR_COPY([AS_TR_SH([DIRECT_$type])], [AS_TR_SH([$comp])]) | |||
| AS_VAR_SET([AS_TR_SH([DIRECT_$type])], [AS_TR_SH([$comp])]) | |||
There was a problem hiding this comment.
I believe AS_VAR_SET Is correct here too, because, simplifying, it would be either AS_VAR_COPY([DIRECT_foo], [comp]) or AS_VAR_SET([DIRECT_foo], [$comp]) but not AS_VAR_COPY([DIRECT_foo], [$comp]). But I didn't test this path.
|
ok to test |
|
@bwbarrett Can you review? |
bwbarrett
approved these changes
Apr 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes two bugs introduced in 000f7e8 that broke
--enable-mca-dso=foo.config: fix --enable-mca-dso: correct the AS_VAR macro
Fix bug introduced in 000f7e8.
AS_VAR_COPY(dest, source) interprets the 'source' argument as a variable name. So, before this patch, the value was not '1', but '$1', which evaluated to garbage and broke the --enable-mca-dso argument.
config: fix --enable-mca-dso: correct copy-paste typo
Typo introduced in 000f7e8.
@bwbarrett