Fix the libnbc MPILAllreduce ring algorithm. #9393
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The ring version did not support MPI_IN_PLACE and had no protection against it, so instead of nicely bailing out was delivering wrong results. This patch addresses this issue, simplifies the computation of the segment sizes, and minimize the temporary memory size. Fixes open-mpi#9385. Signed-off-by: George Bosilca <bosilca@icl.utk.edu>
jsquyres
approved these changes
Oct 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ring version did not support MPI_IN_PLACE and had no protection against it,
so instead of nicely bailing out was delivering wrong results. This patch
addresses this issue, simplifies the computation of the segment sizes, and
minimize the temporary memory size.
Fixes #9385.
Signed-off-by: George Bosilca bosilca@icl.utk.edu