BUFSIZ is undefined in mpiext/affinity.h #9891
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…as prior to 48a71c1 Signed-off-by: Aurelien Bouteiller <bouteill@icl.utk.edu>
|
Maybe it makes reference to the horribly-named BUFSIZ from stdio.h ? |
|
Right - if we want to preserve bufsiz we could just add the stdio.h header. I have no opinion either way. |
|
Prior version (that is prior to the latest change in 48a71c1) of the code would define the MAX to 1024, but would implement using BUFSIZ (including stdio.h from the .c, but not header-visible) which was probably incorrect to start with in the chance case that BUFSIZ would not be set to 1024 on that system. I'm not sure there is a clear rationale for having this particular MPI constant be set to BUFSIZ, as this behavior does not have anything to do with setvbuf of fgets. |
awlauria
approved these changes
Jan 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
including mpi-ext.h in user code causes compilation to fail due to undefined symbol BUFSIZ
BUFSIZ is undefined in mpiext/affinity.h replace it with 1024 as it was prior to 48a71c1
Signed-off-by: Aurelien Bouteiller bouteill@icl.utk.edu