Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add AWS X-Ray Propagator #248

Merged
merged 4 commits into from
Nov 21, 2020
Merged

Add AWS X-Ray Propagator #248

merged 4 commits into from
Nov 21, 2020

Conversation

KKelvinLo
Copy link

@KKelvinLo KKelvinLo commented Nov 18, 2020 •
edited
Loading

Which problem is this PR solving?

This PR adds a propagator for propgating AWS X-Ray headers so that AWS X-Ray is able to receive and read traces from the OpenTelemetry Go SDK.

Short description of the changes

  • Updated Change Log with this change
  • Added AWS X-Ray Propagator
  • Added corresponding unit test for AWS X-Ray Propagator
  • Propagator conforms to (OpenTelemetry propagator specifications)[https://github.com/open-telemetry/opentelemetry-specification/blob/master/specification/context/api-propagators.md] with Inject and Extract defined as required

@KKelvinLo KKelvinLo self-assigned this Nov 18, 2020
alolita
alolita approved these changes Nov 20, 2020
View reviewed changes
Copy link

@alolita alolita left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix name for test func TestJaeger_Extract(t *testing.T)

Add inline comments for each function

@KKelvinLo KKelvinLo merged commit f58734f into master Nov 21, 2020
KKelvinLo added a commit that referenced this pull request Dec 1, 2020
@KKelvinLo
Add AWS X-Ray Propagator (#248)
3560541 
* add AWS X-Ray propagator and tests

* made naming convention changes to adhere to linter

* added comment to interface implementation for  clarity

* update naming convention and added description for method
KKelvinLo added a commit that referenced this pull request Dec 1, 2020
@KKelvinLo
Add AWS X-Ray Propagator (#462)
e1c598c 
* Update CHANGELOG.md

* add space before comment

* Add AWS X-Ray Propagator (#248)

* add AWS X-Ray propagator and tests

* made naming convention changes to adhere to linter

* added comment to interface implementation for  clarity

* update naming convention and added description for method

* add space before comment

* update propagator to use v0.14.0 release changes

* refactor folder and update error messages for clarity

* refactored file structure and naming

* update comment for Propagator struct
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alolita alolita alolita approved these changes

@PettitWesley PettitWesley PettitWesley approved these changes

@wilguo wilguo wilguo approved these changes

Assignees

@KKelvinLo KKelvinLo

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@KKelvinLo @alolita @PettitWesley @wilguo