Skip to content

Commit 3527992

Browse files
cnpalmerzane131
authored andcommitted
Row Repair don't translate invalid repairs
Change-Id: Iff219b44f15cd3d86a647b706496291a6916b49f Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/63302 Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com> Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com> Reviewed-by: Benjamin J. Weisenbeck <bweisenb@us.ibm.com> Reviewed-by: Brian J. Stegmiller <bjs@us.ibm.com> Reviewed-by: Zane C. Shelley <zshelle@us.ibm.com>
1 parent 3203b0f commit 3527992

File tree

1 file changed

+7
-0
lines changed

1 file changed

+7
-0
lines changed

src/usr/fapi2/attribute_service.C

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1871,6 +1871,13 @@ ReturnCode __rowRepairTranslateDramPos(
18711871
uint8_t l_dramPos = (l_dramPosAndSrank >> 3) & 0x1f;
18721872
uint8_t l_srank = l_dramPosAndSrank & 0x07;
18731873

1874+
// The last bit of the row repair stores the validity bit
1875+
bool l_valid = io_translatedData[rank][mss::ROW_REPAIR_BYTE_COUNT-1]
1876+
& 0x01;
1877+
1878+
// If the row repair isn't valid, no need to translate anything
1879+
if ( !l_valid ) continue;
1880+
18741881
uint8_t l_dq = 0;
18751882
l_rc = __dramToDq( i_fapiDimm, l_dramPos, l_dq );
18761883
if ( l_rc )

0 commit comments

Comments
 (0)