Force the refresh/update of attribute overrides at the point of retrieval

This commit will refresh/update the attribute override for the Error Log
Manager (ErrlManager) after it has been immediately retrieved via the
Istep Dispatcher (IStepDispatcher).

Change-Id: I010de99bd66361b2bf4c37fd9dfc7ddd84156d85
CQ: SW491378
Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/98149
Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com>
Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com>
Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com>
Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com>
Reviewed-by: Ilya Smirnov <ismirno@us.ibm.com>
Reviewed-by: Michael Baiocchi <mbaiocch@us.ibm.com>
Reviewed-by: Nicholas E Bofferding <bofferdn@us.ibm.com>

Author: velozr

src/include/usr/errl/errlmanager.H

@@ -5,7 +5,7 @@
 /*                                                                        */
 /* OpenPOWER HostBoot Project                                             */
 /*                                                                        */
-/* Contributors Listed Below - COPYRIGHT 2011,2019                        */
+/* Contributors Listed Below - COPYRIGHT 2011,2020                        */
 /* [+] Google Inc.                                                        */
 /* [+] International Business Machines Corp.                              */
 /*                                                                        */
@@ -116,6 +116,7 @@ enum errlManagerNeeds
     MBOX,
     IPMI,
     ERRLDISP,
+    UPDATE_ATTRIB_VARS,  // Force the refresh/update of attribute variables
 } ;
 
 
@@ -307,6 +308,7 @@ private:
         ERRLOG_ACCESS_ERRLDISP_TYPE        = 0x00000037 | MBOX::FIRST_SECURE_MSG,
         ERRLOG_ACCESS_IPMI_TYPE            = 0x00000038 | MBOX::FIRST_SECURE_MSG,
         ERRLOG_FLUSH_TYPE                  = 0x00000039 | MBOX::FIRST_SECURE_MSG,
+        ERRLOG_UPDATE_ATTRIB_VARS_TYPE     = 0x00000040 | MBOX::FIRST_SECURE_MSG,
     };
 
     /**

src/usr/errl/errlmanager.C

@@ -357,10 +357,21 @@ void ErrlManager::errlogMsgHndlr ()
                     TARGETING::Target * sys = NULL;
                     TARGETING::targetService().getTopLevelTarget( sys );
 
+                    // Cache current 'hidden error log enable' value for tracing
+                    auto l_hiddenErrLogsEnableOldValue = iv_hiddenErrLogsEnable;
+
                     // set whether we want to skip certain error logs or not.
                     iv_hiddenErrLogsEnable =
                           sys->getAttr<TARGETING::ATTR_HIDDEN_ERRLOGS_ENABLE>();
 
+                    TRACFCOMP( g_trac_errl, INFO_MRK
+                    "ErrlManager::errlogMsgHndlr(ERRLOG_ACCESS_TARG_TYPE"
+                    "(0x%02X)) - updating 'hidden error logs enable' "
+                    "from 0x%02X to 0x%02X",
+                    ERRLOG_ACCESS_TARG_TYPE,
+                    l_hiddenErrLogsEnableOldValue,
+                    iv_hiddenErrLogsEnable  );
+
                     TARGETING::SpFunctions spfn;
 
                     if (!(sys &&
@@ -384,6 +395,29 @@ void ErrlManager::errlogMsgHndlr ()
                     //We are done with the msg
                     msg_free(theMsg);
 
+                    // go back and wait for a next msg
+                    break;
+                }
+            case ERRLOG_UPDATE_ATTRIB_VARS_TYPE:
+                {
+                    TARGETING::Target * sys(nullptr);
+                    TARGETING::targetService().getTopLevelTarget( sys );
+
+                    // Cache current 'hidden error log enable' value for tracing
+                    auto l_hiddenErrLogsEnableOldValue = iv_hiddenErrLogsEnable;
+
+                    // Refresh/update attribute vars
+                    iv_hiddenErrLogsEnable =
+                          sys->getAttr<TARGETING::ATTR_HIDDEN_ERRLOGS_ENABLE>();
+
+                    TRACFCOMP( g_trac_errl, INFO_MRK
+                    "ErrlManager::errlogMsgHndlr(ERRLOG_UPDATE_ATTRIB_VARS_TYPE"
+                    "(0x%02X)) - updating 'hidden error logs enable' "
+                    "from 0x%02X to 0x%02X",
+                    ERRLOG_UPDATE_ATTRIB_VARS_TYPE,
+                    l_hiddenErrLogsEnableOldValue,
+                    iv_hiddenErrLogsEnable  );
+
                     // go back and wait for a next msg
                     break;
                 }
@@ -941,6 +975,9 @@ void ErrlManager::sendResourcesMsg(errlManagerNeeds i_needs)
         case ERRLDISP:
             msg->type = ERRORLOG::ErrlManager::ERRLOG_ACCESS_ERRLDISP_TYPE;
             break;
+        case UPDATE_ATTRIB_VARS:
+            msg->type = ERRORLOG::ErrlManager::ERRLOG_UPDATE_ATTRIB_VARS_TYPE;
+            break;
         default:
         {
             TRACFCOMP( g_trac_errl, ERR_MRK "bad msg!!");

src/usr/initservice/istepdispatcher/istepdispatcher.C

@@ -262,7 +262,16 @@ void IStepDispatcher::init(errlHndl_t &io_rtaskRetErrl)
                     break;
                 }
             }
-        }
+
+            TRACFCOMP( g_trac_initsvc, "IStepDispatcher: init: calling "
+                      "ERRORLOG::ErrlManager::errlResourceReady"
+                      "(ERRORLOG::UPDATE_ATTRIB_VARS(0x%02X))",
+                      ERRORLOG::UPDATE_ATTRIB_VARS );
+
+            // Inform ErrlManager to reread any attribute values that it may
+            // have cached away in the event that those values were overridden.
+            ERRORLOG::ErrlManager::errlResourceReady(ERRORLOG::UPDATE_ATTRIB_VARS);
+        }  // end if(!iv_spBaseServicesEnabled)
 
         iv_istepMode = l_pTopLevelTarget->getAttr<TARGETING::ATTR_ISTEP_MODE>();