Skip to content

Commit d2bcdef

Browse files
Ilya Smirnovdcrowell77
authored andcommitted
Add Printk Traces to ThreadPool Unit Tests
Some ThreadPool unit tests that test crashed tasks were missing printk logs to indicate the crashes were expected. This creates confusion when debugging printk logs. This commit adds the traces to indicate the crashes are expected and are part of the test. Change-Id: I38d2d886cfd73106e32fb4e461bba3d5a39a8032 Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/83783 Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com> Reviewed-by: Christian R Geddes <crgeddes@us.ibm.com> Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com> Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com> Reviewed-by: Nicholas E Bofferding <bofferdn@us.ibm.com> Reviewed-by: Daniel M Crowell <dcrowell@us.ibm.com>
1 parent 69f3bd2 commit d2bcdef

File tree

1 file changed

+3
-0
lines changed

1 file changed

+3
-0
lines changed

src/usr/util/test/threadpool.H

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -31,6 +31,7 @@
3131
#include <errl/errlmanager.H>
3232
#include <util/util_reasoncodes.H>
3333
#include <hbotcompid.H>
34+
#include <kernel/console.H>
3435

3536
// Thread pool constructor flags
3637
#define DISABLE_CHILD_RC_CHECKING false
@@ -256,6 +257,7 @@ class ThreadPoolTest: public CxxTest::TestSuite
256257
errlHndl_t l_errl = nullptr;
257258

258259
do {
260+
printk("testChildRCCrashedTask: Expect to see uncaught exception\n");
259261
l_threadPool.insert(new __ThreadPoolTest::CrashedTask());
260262
l_threadPool.start();
261263
l_errl = l_threadPool.shutdown();
@@ -300,6 +302,7 @@ class ThreadPoolTest: public CxxTest::TestSuite
300302
l_threadPool(DISABLE_CHILD_RC_CHECKING);
301303
errlHndl_t l_errl = nullptr;
302304

305+
printk("testChildNoRCCrashedTask: Expect to see uncaught exception\n");
303306
l_threadPool.insert(new __ThreadPoolTest::CrashedTask());
304307
l_threadPool.start();
305308
l_errl = l_threadPool.shutdown();

0 commit comments

Comments
 (0)