Skip to content

Commit f36692f

Browse files
Li Mengdcrowell77
authored andcommitted
Fixes LRDIMM set rank presence bug
Change-Id: I992802bf2f40fdda4ca267e50211e993a7549ddd Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/72610 Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com> Reviewed-by: Louis Stermole <stermole@us.ibm.com> Reviewed-by: STEPHEN GLANCY <sglancy@us.ibm.com> Reviewed-by: Jennifer A. Stofer <stofer@us.ibm.com> Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/103319 Reviewed-by: Daniel M Crowell <dcrowell@us.ibm.com> Tested-by: Daniel M Crowell <dcrowell@us.ibm.com>
1 parent 6dee960 commit f36692f

File tree

1 file changed

+4
-5
lines changed

1 file changed

+4
-5
lines changed

src/import/chips/p9/procedures/hwp/memory/lib/phy/mss_lrdimm_training_helper.C

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -229,15 +229,14 @@ fapi2::ReturnCode set_rank_presence( const fapi2::Target<fapi2::TARGET_TYPE_DIMM
229229
const auto& l_mcbist = mss::find_target<fapi2::TARGET_TYPE_MCBIST>(i_target);
230230
const auto& l_mca = mss::find_target<fapi2::TARGET_TYPE_MCA>(i_target);
231231

232-
uint8_t l_sim = 0;
233-
FAPI_TRY(mss::is_simulation(l_sim));
234-
235-
static const std::vector< cw_info > l_bcw_info =
232+
const std::vector< cw_info > l_bcw_info =
236233
{
237-
238234
{ FUNC_SPACE_0, RANK_PRESENCE_CW, i_rank, mss::tmrc() , CW4_DATA_LEN, cw_info::BCW},
239235
};
240236

237+
uint8_t l_sim = 0;
238+
FAPI_TRY(mss::is_simulation(l_sim));
239+
241240
// DES first - make sure those CKE go high and stay there
242241
l_program.iv_instructions.push_back(mss::ccs::des_command<fapi2::TARGET_TYPE_MCBIST>());
243242

0 commit comments

Comments
 (0)