Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding diff_drive dependencies for caddy #111

Merged
merged 1 commit into from
Nov 30, 2021

Conversation

marcoag
Copy link
Member

@marcoag marcoag commented Nov 23, 2021

Signed-off-by: Marco A. Gutierrez marco@openrobotics.org

Bug fix

Fixed bug

The Caddy model has this hack to use the libgazebo_ros_diff_drive.so and libignition-gazebo-diff-drive-system.so plugins whenever needed. However, these plugins have to be manually installed as they are not declared as a dependency anywhere.

Fix applied

Technically the correct place for the dependency would be rmf_demos_assets but this would defeat the previous effort on dividing packages so people can install only ignition or gazebo demo related packages independently. Therefore I'm adding these dependencies to rmf_demos_gz and rmf_demos_ign respectively to solve the issue.

Signed-off-by: Marco A. Gutierrez <marco@openrobotics.org>
@marcoag marcoag merged commit f30ce7c into main Nov 30, 2021
@marcoag marcoag deleted the fix/caddy_plugin_dependencies branch November 30, 2021 02:28
marcoag pushed a commit that referenced this pull request Dec 1, 2021
Signed-off-by: Marco A. Gutierrez <marco@openrobotics.org>
xiyuoh pushed a commit to xiyuoh/rmf_demos that referenced this pull request Mar 15, 2022
Signed-off-by: Marco A. Gutierrez <marco@openrobotics.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants