adding diff_drive dependencies for caddy #111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Marco A. Gutierrez <marco@openrobotics.org>
luca-della-vedova
approved these changes
Nov 25, 2021
marcoag
pushed a commit
that referenced
this pull request
Dec 1, 2021
Signed-off-by: Marco A. Gutierrez <marco@openrobotics.org>
xiyuoh
pushed a commit
to xiyuoh/rmf_demos
that referenced
this pull request
Mar 15, 2022
Signed-off-by: Marco A. Gutierrez <marco@openrobotics.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Marco A. Gutierrez marco@openrobotics.org
Bug fix
Fixed bug
The Caddy model has this hack to use the
libgazebo_ros_diff_drive.soandlibignition-gazebo-diff-drive-system.soplugins whenever needed. However, these plugins have to be manually installed as they are not declared as a dependency anywhere.Fix applied
Technically the correct place for the dependency would be
rmf_demos_assetsbut this would defeat the previous effort on dividing packages so people can install onlyignitionorgazebodemo related packages independently. Therefore I'm adding these dependencies tormf_demos_gzandrmf_demos_ignrespectively to solve the issue.