-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding server_uri for dispatcher node #230
Conversation
Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
By changing the default value for
I think we should be consistent and keep the default parameter value for
The user needs to figure out that
I expect this to cause significant confusion for users. |
Signed-off-by: Aaron Chong <aaronchongth@gmail.com> (cherry picked from commit 05504d9) Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
Signed-off-by: Aaron Chong <aaronchongth@gmail.com> (cherry picked from commit 05504d9) Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
New feature implementation
Implemented feature
Related to open-rmf/rmf_ros2#355.
Gives the dispatcher node websocket access to servers