Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clean flask-cors rosdep #30

Closed
wants to merge 1 commit into from
Closed

clean flask-cors rosdep #30

wants to merge 1 commit into from

Conversation

youliangtan
Copy link
Member

Remove flask-cors since not avail during rosdep installation

Signed-off-by: youliang <tan_you_liang@hotmail.com>
@codebot
Copy link
Contributor

codebot commented Apr 12, 2021

I think we can (should?) add this as a rosdep if it's needed during runtime.

@codebot
Copy link
Contributor

codebot commented Apr 12, 2021

I think these are the docs for adding rosdeps upstream (maybe there is a newer one somewhere, I'm not sure): https://docs.ros.org/en/independent/api/rosdep/html/contributing_rules.html

@codebot
Copy link
Contributor

codebot commented Apr 12, 2021

It looks like there is a flask-cors already in there, but it uses pip instead of apt, I'm not sure why: https://github.com/ros/rosdistro/blob/master/rosdep/python.yaml#L1636-L1642

@Yadunund
Copy link
Member

Looks like its a python2 package? It's missing definitions for python3-flask-cors

@youliangtan
Copy link
Member Author

Good Idea. In this case, we should add it to rosdep. Will keep this track open, and I will open a pr there.

@Yadunund
Copy link
Member

@tanyouliang95 there is an issue ticket open for other dependencies too. Perhaps you could address all of them?
open-rmf/rmf#27

@youliangtan
Copy link
Member Author

Open PR: ros/rosdistro#29086

@youliangtan
Copy link
Member Author

youliangtan commented Apr 15, 2021

Will close this after added python3-flask-cors to https://github.com/ros/rosdistro/blob/df4656b9b9e4485924f7b4a5deddcb12ae25b890/rosdep/python.yaml#L6020

Will require to rosdep update to update this locally.

@Yadunund
Copy link
Member

Awesome, thanks for getting these into rosdep @tanyouliang95!
Are the other packages python3-shapely python3-yaml python3-requests already available upstream?

@youliangtan
Copy link
Member Author

Yes, i think they got updated along the way. Can check it out here

@youliangtan youliangtan deleted the fix/panel-dep branch April 15, 2021 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants