-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add python3-flask-cors and python3-flask-socketio #29086
Conversation
Signed-off-by: youliang <tan_you_liang@hotmail.com>
Signed-off-by: youliang <tan_you_liang@hotmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is expected that pip versions will be ahead of the apt package versions. However for consistency we use the system packaged versions if they are available as that is what other users on the system expect if they are available and has been cross validated with other libraries.
rosdep/python.yaml
Outdated
packages: [flask-socketio] | ||
ubuntu: | ||
pip: | ||
packages: [flask-socketio] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not a parallel implelementation and will conflict with a system install. 5.0 is already packaged for hirsute: https://packages.ubuntu.com/source/hirsute/flask-socketio
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Make sense, fixed. c9f227f
rosdep/python.yaml
Outdated
python3-flask-socketio: | ||
debian: | ||
pip: | ||
packages: [flask-socketio] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The debian version has 5.0 already: https://packages.debian.org/bullseye/python3-flask-socketio
Signed-off-by: youliang <tan_you_liang@hotmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for the quick fixup. It's always frustrating waiting for newer versions to land in distros.
Package name:
flask-cors
andflask-socketio
Purpose of using this:
This is used by https://github.com/open-rmf/rmf_demos/ 's
rmf_demos_panel
web serverLinks to Distribution Packages
python3-flask-cors
flask-socketio
flask-socketio
is version 4.x . A latest version of 5.X is prefered as it not backward compatible.Edit: After feedback, will switch back
flask-socketio
to deb and ubuntu package for consistency