Add python3-flask-cors and python3-flask-socketio #29086
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: youliang <tan_you_liang@hotmail.com>
Signed-off-by: youliang <tan_you_liang@hotmail.com>
tfoote
requested changes
Apr 13, 2021
There was a problem hiding this comment.
It is expected that pip versions will be ahead of the apt package versions. However for consistency we use the system packaged versions if they are available as that is what other users on the system expect if they are available and has been cross validated with other libraries.
rosdep/python.yaml
Outdated
| packages: [flask-socketio] | ||
| ubuntu: | ||
| pip: | ||
| packages: [flask-socketio] |
There was a problem hiding this comment.
This is not a parallel implelementation and will conflict with a system install. 5.0 is already packaged for hirsute: https://packages.ubuntu.com/source/hirsute/flask-socketio
There was a problem hiding this comment.
Make sense, fixed. c9f227f
rosdep/python.yaml
Outdated
| python3-flask-socketio: | ||
| debian: | ||
| pip: | ||
| packages: [flask-socketio] |
There was a problem hiding this comment.
The debian version has 5.0 already: https://packages.debian.org/bullseye/python3-flask-socketio
Signed-off-by: youliang <tan_you_liang@hotmail.com>
tfoote
approved these changes
Apr 13, 2021
cottsay
approved these changes
Apr 14, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Package name:
flask-corsandflask-socketioPurpose of using this:
This is used by https://github.com/open-rmf/rmf_demos/ 's
rmf_demos_panelweb serverLinks to Distribution Packages
python3-flask-cors
flask-socketio
flask-socketiois version 4.x . A latest version of 5.X is prefered as it not backward compatible.Edit: After feedback, will switch back
flask-socketioto deb and ubuntu package for consistency