-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Accommodate finishing task #108
Conversation
Signed-off-by: Yadunund <yadunund@openrobotics.org>
Signed-off-by: Yadunund <yadunund@openrobotics.org>
Signed-off-by: Yadunund <yadunund@openrobotics.org>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These changes look good to me, although I think it's highlighting the need to switch to dynamically defined tasks instead of these static task types.
We just need to wait for open-rmf/rmf_task#28 before merging.
Signed-off-by: Yadunund <yadunund@openrobotics.org>
Signed-off-by: Yadunund <yadunund@openrobotics.org>
Signed-off-by: Yadunund <yadunund@openrobotics.org>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!
I'm going to merge open-rmf/rmf_task#28 first and then watch CI on this PR to make sure it's all good before merging.
Signed-off-by: Yadunund <yadunund@openrobotics.org> Signed-off-by: Arjo Chakravarty <arjo@openrobotics.org>
PR open-rmf/rmf_task#28 allows for a
RequestFactory
to be supplied when task allocation planning. The request generated by theRequestFactory
is automatically appended to the end of the task queue for all agents. This is very useful when you want robots in a fleet to always perform a certain task after finishing other requested tasks. For example, if we do not want robots to remain idle after their last performed task and instead want them to recharge their batteries, we can supply theChargeBatteryFactory
to the task planner which will automatically append aChargeBattery
task to the end of the robot's task queues.This PR:
FleetUpdateHandle::set_task_planner_params()
to optionally accept aRequestFactory
full_control
launch file and src to allow users to set the fleet adapter's task planner with eitherChargeBatteryFactory
orParkRobotFactory