Handle empty startset in full_control #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yadunund <yadunund@openrobotics.org>
mxgrey
requested changes
Mar 24, 2021
mxgrey
reviewed
Mar 24, 2021
|
One other suggestion for this PR: Let's have the |
Signed-off-by: Yadunund <yadunund@openrobotics.org>
Signed-off-by: Yadunund <yadunund@openrobotics.org>
Co-authored-by: Grey <grey@openrobotics.org> Signed-off-by: Yadunund <yadunund@openrobotics.org>
Yadunund
force-pushed
the
bug/full_control_starts
branch
from
8bda9d1
to
8d7189d
Compare
mxgrey
reviewed
Mar 24, 2021
Signed-off-by: Yadunund <yadunund@openrobotics.org>
Signed-off-by: Yadunund <yadunund@openrobotics.org>
|
I can confirm this fixes osrf/rmf_core/#266. It would be useful to inform the user why exactly the start set is empty. |
Signed-off-by: Michael X. Grey <grey@openrobotics.org>
|
@Achllle I've added some more information to the error message that may help debug the problem. |
mxgrey
approved these changes
Mar 29, 2021
|
Amazing, those debug messages are very helpful @mxgrey |
mxgrey
pushed a commit
that referenced
this pull request
Apr 22, 2021
* add CI and docs gen * use rmf src instead of rolling
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Yadunund yadunund@openrobotics.org
Bug fix
Fixed bug
Fix for #12
Fix applied
Check if output of `compute_plan_starts() is empty and if so return after outputting an error