Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change default task auction evaluator to QuickestFinishEvaluator #211

Merged
merged 1 commit into from
May 24, 2022

Conversation

mxgrey
Copy link
Contributor

@mxgrey mxgrey commented May 23, 2022

It seems the default task auction evaluator was reverted to a less preferable class during the refactoring of #168. This PR switches it back to the "Quickest Finish" evaluator, which should help optimize the finish times of all tasks.

Much thanks to @jkeshav-bvignesh for pointing out this issue.

Signed-off-by: Michael X. Grey <grey@openrobotics.org>
@codecov
Copy link

codecov bot commented May 23, 2022

Codecov Report

Merging #211 (f4b04a7) into main (b1676a0) will increase coverage by 0.03%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #211      +/-   ##
==========================================
+ Coverage   17.77%   17.80%   +0.03%     
==========================================
  Files         422      844     +422     
  Lines       38906    77812   +38906     
  Branches    18686    37372   +18686     
==========================================
+ Hits         6916    13856    +6940     
- Misses      24552    49060   +24508     
- Partials     7438    14896    +7458     
Flag Coverage Δ
tests 17.80% <ø> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...xcpp/RxCpp-4.1.0/Rx/v2/src/rxcpp/rx-observable.hpp
.../src/rmf_traffic_ros2/schedule/NegotiationRoom.cpp
...4.1.0/Rx/v2/src/rxcpp/schedulers/rx-sameworker.hpp
...2/rmf_fleet_adapter/test/phases/test_DoorClose.cpp
...dapter/src/rmf_fleet_adapter/project_itinerary.cpp
...mf_ros2/rmf_fleet_adapter/src/close_lanes/main.cpp
...mf_rxcpp/include/rmf_rxcpp/detail/RxJobsDetail.hpp
...rc/rmf_traffic_ros2/schedule/convert_Itinerary.cpp
...xCpp-4.1.0/Rx/v2/src/rxcpp/sources/rx-interval.hpp
...fleet_adapter/src/rmf_fleet_adapter/load_param.hpp
... and 1256 more

@mxgrey mxgrey merged commit 8440488 into main May 24, 2022
@mxgrey mxgrey deleted the fix/quickest_finish branch May 24, 2022 02:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants