Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow GoToPlace to know about expected future destinations #61

Merged
merged 5 commits into from
May 5, 2022

Conversation

mxgrey
Copy link
Contributor

@mxgrey mxgrey commented May 5, 2022

A potential issue with the go_to_place activity is the scheduling system might not work correctly if the robot needs to go to a location temporarily, and other robots also want to go to that same location, either temporarily or permanently. The two agents will have difficulty negotiating a smooth, consistent solution to their conflict.

Adding in fields for the expected next destinations that the agent will go to after it arrives at the current destination will help the scheduling system smooth out these conflicts.

Signed-off-by: Michael X. Grey <grey@openrobotics.org>
@mxgrey mxgrey requested a review from aaronchongth May 5, 2022 04:19
@codecov
Copy link

codecov bot commented May 5, 2022

Codecov Report

Merging #61 (5901086) into main (a5e294a) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main      #61   +/-   ##
=======================================
  Coverage   36.21%   36.21%           
=======================================
  Files          65       65           
  Lines        2491     2491           
  Branches     1366     1366           
=======================================
  Hits          902      902           
  Misses        552      552           
  Partials     1037     1037           
Flag Coverage Δ
tests 36.21% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

aaronchongth
aaronchongth previously approved these changes May 5, 2022
Copy link
Member

@aaronchongth aaronchongth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

mxgrey added 2 commits May 5, 2022 15:20
Signed-off-by: Michael X. Grey <grey@openrobotics.org>
@mxgrey
Copy link
Contributor Author

mxgrey commented May 5, 2022

@aaronchongth sorry to dismiss your review, I just remembered to update the changelog.

Copy link
Member

@aaronchongth aaronchongth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No worries, thanks for remembering that 🙇

@@ -1,5 +1,9 @@
## Changelog for package rmf_task

2.1.0 (2022-XX-YY)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
2.1.0 (2022-XX-YY)
2.1.0 (2022-05-05)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apologies, I noticed a mistake in my review. I believe we will need this change log in rmf_task_sequence instead of rmf_task.

Just checked in with @marcoag, it sounds like we will need all packages in this repo to have mentioned this minor version, even if there were no changes to the packages.

Signed-off-by: Michael X. Grey <grey@openrobotics.org>
@mxgrey
Copy link
Contributor Author

mxgrey commented May 5, 2022

Whoops, you're right! I've moved the changes to rmf_task_sequence's log and created a placeholder in rmf_task. For now I'm keeping the dates anonymous since I don't know when the next release will happen.

Copy link
Member

@aaronchongth aaronchongth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah! Gotcha, that makes sense. I'm gonna guess more features or fixes can be piled into this minor version before a release then. LGTM!

@mxgrey mxgrey merged commit 63fce74 into main May 5, 2022
@mxgrey mxgrey deleted the followed_by branch May 5, 2022 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants