Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix build with Apple Clang #77

Merged
merged 2 commits into from
May 23, 2023
Merged

Fix build with Apple Clang #77

merged 2 commits into from
May 23, 2023

Conversation

Yadunund
Copy link
Member

Building on macOS with Apple Clang as default compiler throws a build error due to a missing include for unordered_map.

Fix build with apple clang
9157a42 
Signed-off-by: Yadunund <yadunund@openorbotics.org>
@Yadunund Yadunund requested a review from mxgrey January 25, 2023 12:36
aaronchongth
aaronchongth approved these changes May 22, 2023
View reviewed changes
Copy link
Member

@aaronchongth aaronchongth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the fix!

@Yadunund Yadunund merged commit bcaf82a into main May 23, 2023
@Yadunund Yadunund deleted the yadu/fix_build_with_apple_clang branch May 23, 2023 05:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aaronchongth aaronchongth aaronchongth approved these changes

@mxgrey mxgrey Awaiting requested review from mxgrey

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Yadunund @aaronchongth