Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build with Apple Clang #27

Merged
merged 3 commits into from
May 29, 2024
Merged

Fix build with Apple Clang #27

merged 3 commits into from
May 29, 2024

Conversation

Yadunund
Copy link
Member

@Yadunund Yadunund commented Jan 25, 2023

The default compiler on macOS devices is Apple Clang which throws an error for undefined std::to_string() call. This PR adds the <string> include to fix compilation.

/Users/yadunund/ws_rmf/install/rmf_utils/include/rmf_utils/Modular.hpp:64:22: error: no member named 'to_string' in namespace 'std'
              + std::to_string(Window));

Signed-off-by: Yadunund <yadunund@openorbotics.org>
@luca-della-vedova
Copy link
Member

Trivial "include-what-you-use"

@luca-della-vedova
Copy link
Member

First commit not signed, can you sign off / force push?

@mxgrey mxgrey merged commit f4a2ea6 into main May 29, 2024
1 check passed
@mxgrey mxgrey deleted the yadu/fix_build_with_apple_clang branch May 29, 2024 12:29
@mxgrey
Copy link
Contributor

mxgrey commented May 29, 2024

I've used admin powers to override the DCO requirement for such a trivial and obviously necessary change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants