Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add result validation #7

Merged
merged 3 commits into from
Apr 22, 2019
Merged

fix: add result validation #7

merged 3 commits into from
Apr 22, 2019

Conversation

shanejonas
Copy link
Member

@shanejonas shanejonas commented Apr 22, 2019 •
edited
Loading

fixes #6

image

@shanejonas shanejonas requested a review from zcstarr April 22, 2019 17:05
zcstarr
zcstarr approved these changes Apr 22, 2019
View reviewed changes
Copy link
Member

@zcstarr zcstarr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this looks good. Nice result set validation add! 🚢 with comment

src/coverage.ts Outdated Show resolved Hide resolved
zcstarr and others added 2 commits April 22, 2019 12:26
@zcstarr @shanejonas
fix(coverage): use await for results
d555319 
Co-Authored-By: shanejonas <jonas.shane@gmail.com>
@shanejonas
fix(coverage): use await for callResults
aa5c451 
fixes #7
@shanejonas shanejonas merged commit 8b93468 into master Apr 22, 2019
@shanejonas shanejonas deleted the fix/result-validation branch April 22, 2019 20:13
@shanejonas shanejonas mentioned this pull request Apr 22, 2019
Closed
@shanejonas
Copy link
Member Author

🎉 This PR is included in version 1.0.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zcstarr zcstarr zcstarr approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Validate return values
2 participants
@shanejonas @zcstarr