Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: use swr instead of custom fetching from the API #444

Closed
brandonroberts opened this issue Sep 27, 2022 · 6 comments · Fixed by #443
Closed

refactor: use swr instead of custom fetching from the API #444

brandonroberts opened this issue Sep 27, 2022 · 6 comments · Fixed by #443

Comments

@brandonroberts
Copy link
Contributor

    this needs swr, we can't do custom fetching from the API

Originally posted by @0-vortex in #441 (comment)

@0-vortex
Copy link
Contributor

    this needs swr, we can't do custom fetching from the API

Originally posted by @0-vortex in #441 (comment)

I think this should be done inside the PR if not already merged, not leveraging the swr mutations will change the implementation logic and the wrapper/container pattern we are forced to use now, if not able to do it now i would still count as high priority

@brandonroberts
Copy link
Contributor Author

brandonroberts commented Sep 27, 2022

Its addressed here 765dfc2 by this PR #443

@0-vortex
Copy link
Contributor

Awesome 🥂

github-actions bot pushed a commit that referenced this issue Sep 27, 2022
## [1.7.0-beta.11](v1.7.0-beta.10...v1.7.0-beta.11) (2022-09-27)

### 🐛 Bug Fixes

* remove remaining mock data for contributors ([#443](#443)) ([974c739](974c739)), closes [#404](#404) [#444](#444)
@github-actions
Copy link

🎉 This issue has been resolved in version 1.7.0-beta.11 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

github-actions bot pushed a commit that referenced this issue Sep 28, 2022
## [1.8.0-beta.1](v1.7.0...v1.8.0-beta.1) (2022-09-28)

### 🍕 Features

* add data from API to contributors page for hacktoberfest ([#431](#431)) ([56e12ea](56e12ea)), closes [#404](#404)
* Add truncate string for long pr names ([#440](#440)) ([35b8541](35b8541)), closes [#438](#438)
* adds initial support for restricting reports by user roles ([#451](#451)) ([15a7643](15a7643)), closes [#395](#395)

### 🐛 Bug Fixes

* adds links to footer ([#432](#432)) ([7adfbe7](7adfbe7))
* inverse the scatter chart ([#433](#433)) ([18dd094](18dd094)), closes [#399](#399)
* limit number of languages in contibutor's card ([#441](#441)) ([4aba355](4aba355)), closes [#402](#402)
* remove link from highlight card component ([#435](#435)) ([25b6997](25b6997))
* remove remaining mock data for contributors ([#443](#443)) ([974c739](974c739)), closes [#404](#404) [#444](#444)
@github-actions
Copy link

🎉 This issue has been resolved in version 1.8.0-beta.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

github-actions bot pushed a commit that referenced this issue Sep 28, 2022
## [1.8.0](v1.7.0...v1.8.0) (2022-09-28)

### 🍕 Features

* add data from API to contributors page for hacktoberfest ([#431](#431)) ([56e12ea](56e12ea)), closes [#404](#404)
* Add truncate string for long pr names ([#440](#440)) ([35b8541](35b8541)), closes [#438](#438)
* adds initial support for restricting reports by user roles ([#451](#451)) ([15a7643](15a7643)), closes [#395](#395)

### 🐛 Bug Fixes

* adds links to footer ([#432](#432)) ([7adfbe7](7adfbe7))
* inverse the scatter chart ([#433](#433)) ([18dd094](18dd094)), closes [#399](#399)
* limit number of languages in contibutor's card ([#441](#441)) ([4aba355](4aba355)), closes [#402](#402)
* remove link from highlight card component ([#435](#435)) ([25b6997](25b6997))
* remove remaining mock data for contributors ([#443](#443)) ([974c739](974c739)), closes [#404](#404) [#444](#444)
@github-actions
Copy link

🎉 This issue has been resolved in version 1.8.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

ElpisHelle added a commit to ElpisHelle/next.js-tailwindcss that referenced this issue Aug 17, 2023
## [1.7.0-beta.11](open-sauced/app@v1.7.0-beta.10...v1.7.0-beta.11) (2022-09-27)

### 🐛 Bug Fixes

* remove remaining mock data for contributors ([#443](open-sauced/app#443)) ([974c739](open-sauced/app@974c739)), closes [#404](open-sauced/app#404) [#444](open-sauced/app#444)
ElpisHelle added a commit to ElpisHelle/next.js-tailwindcss that referenced this issue Aug 17, 2023
## [1.8.0-beta.1](open-sauced/app@v1.7.0...v1.8.0-beta.1) (2022-09-28)

### 🍕 Features

* add data from API to contributors page for hacktoberfest ([#431](open-sauced/app#431)) ([56e12ea](open-sauced/app@56e12ea)), closes [#404](open-sauced/app#404)
* Add truncate string for long pr names ([#440](open-sauced/app#440)) ([35b8541](open-sauced/app@35b8541)), closes [#438](open-sauced/app#438)
* adds initial support for restricting reports by user roles ([#451](open-sauced/app#451)) ([15a7643](open-sauced/app@15a7643)), closes [#395](open-sauced/app#395)

### 🐛 Bug Fixes

* adds links to footer ([#432](open-sauced/app#432)) ([7adfbe7](open-sauced/app@7adfbe7))
* inverse the scatter chart ([#433](open-sauced/app#433)) ([18dd094](open-sauced/app@18dd094)), closes [#399](open-sauced/app#399)
* limit number of languages in contibutor's card ([#441](open-sauced/app#441)) ([4aba355](open-sauced/app@4aba355)), closes [#402](open-sauced/app#402)
* remove link from highlight card component ([#435](open-sauced/app#435)) ([25b6997](open-sauced/app@25b6997))
* remove remaining mock data for contributors ([#443](open-sauced/app#443)) ([974c739](open-sauced/app@974c739)), closes [#404](open-sauced/app#404) [#444](open-sauced/app#444)
ElpisHelle added a commit to ElpisHelle/next.js-tailwindcss that referenced this issue Aug 17, 2023
## [1.8.0](open-sauced/app@v1.7.0...v1.8.0) (2022-09-28)

### 🍕 Features

* add data from API to contributors page for hacktoberfest ([#431](open-sauced/app#431)) ([56e12ea](open-sauced/app@56e12ea)), closes [#404](open-sauced/app#404)
* Add truncate string for long pr names ([#440](open-sauced/app#440)) ([35b8541](open-sauced/app@35b8541)), closes [#438](open-sauced/app#438)
* adds initial support for restricting reports by user roles ([#451](open-sauced/app#451)) ([15a7643](open-sauced/app@15a7643)), closes [#395](open-sauced/app#395)

### 🐛 Bug Fixes

* adds links to footer ([#432](open-sauced/app#432)) ([7adfbe7](open-sauced/app@7adfbe7))
* inverse the scatter chart ([#433](open-sauced/app#433)) ([18dd094](open-sauced/app@18dd094)), closes [#399](open-sauced/app#399)
* limit number of languages in contibutor's card ([#441](open-sauced/app#441)) ([4aba355](open-sauced/app@4aba355)), closes [#402](open-sauced/app#402)
* remove link from highlight card component ([#435](open-sauced/app#435)) ([25b6997](open-sauced/app@25b6997))
* remove remaining mock data for contributors ([#443](open-sauced/app#443)) ([974c739](open-sauced/app@974c739)), closes [#404](open-sauced/app#404) [#444](open-sauced/app#444)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants