-
-
Notifications
You must be signed in to change notification settings - Fork 202
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add data from API to contributors page for hacktoberfest #431
Conversation
β Deploy Preview for design-insights ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
β Deploy Preview for oss-insights ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
e0bfcb1
to
870a49e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a non-blocking comment about 0d
. Approved to unblock the following issues.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! π
Quick note Brandon. Was looking through your PR and noticed that you're still using the fake data for number of PRs. Probably was done before the pr endpoint was finished but you should be able to get the total number of PRs for each contributor to add to the contributor table now. Also after that, you probably don't need useContributorData anymore since it only has mockData. Just wanted to point that out and great job on this. The contributor page looks absolutely amazing! |
Thanks @chadstewart! That's correct. That's one more piece to add to the contributors endpoint and then I'll remove the last bit from the mock data. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR Compliance Checks
Thank you for your Pull Request! We have run several checks on this pull request in order to make sure it's suitable for merging into this project. The results are listed in the following section.
Issue Reference
In order to be considered for merging, the pull request description must refer to a specific issue number. This is described in our Contributing Guide.
This check is looking for a phrase similar to: "Fixes #XYZ" or "Resolves #XYZ" where XYZ is the issue number that this PR is meant to address.
π This PR is included in version 1.7.0-beta.10 π The release is available on GitHub release Your semantic-release bot π¦π |
## [1.8.0-beta.1](v1.7.0...v1.8.0-beta.1) (2022-09-28) ### π Features * add data from API to contributors page for hacktoberfest ([#431](#431)) ([56e12ea](56e12ea)), closes [#404](#404) * Add truncate string for long pr names ([#440](#440)) ([35b8541](35b8541)), closes [#438](#438) * adds initial support for restricting reports by user roles ([#451](#451)) ([15a7643](15a7643)), closes [#395](#395) ### π Bug Fixes * adds links to footer ([#432](#432)) ([7adfbe7](7adfbe7)) * inverse the scatter chart ([#433](#433)) ([18dd094](18dd094)), closes [#399](#399) * limit number of languages in contibutor's card ([#441](#441)) ([4aba355](4aba355)), closes [#402](#402) * remove link from highlight card component ([#435](#435)) ([25b6997](25b6997)) * remove remaining mock data for contributors ([#443](#443)) ([974c739](974c739)), closes [#404](#404) [#444](#444)
π This PR is included in version 1.8.0-beta.1 π The release is available on GitHub release Your semantic-release bot π¦π |
## [1.8.0](v1.7.0...v1.8.0) (2022-09-28) ### π Features * add data from API to contributors page for hacktoberfest ([#431](#431)) ([56e12ea](56e12ea)), closes [#404](#404) * Add truncate string for long pr names ([#440](#440)) ([35b8541](35b8541)), closes [#438](#438) * adds initial support for restricting reports by user roles ([#451](#451)) ([15a7643](15a7643)), closes [#395](#395) ### π Bug Fixes * adds links to footer ([#432](#432)) ([7adfbe7](7adfbe7)) * inverse the scatter chart ([#433](#433)) ([18dd094](18dd094)), closes [#399](#399) * limit number of languages in contibutor's card ([#441](#441)) ([4aba355](4aba355)), closes [#402](#402) * remove link from highlight card component ([#435](#435)) ([25b6997](25b6997)) * remove remaining mock data for contributors ([#443](#443)) ([974c739](974c739)), closes [#404](#404) [#444](#444)
π This PR is included in version 1.8.0 π The release is available on GitHub release Your semantic-release bot π¦π |
## [1.7.0-beta.10](open-sauced/app@v1.7.0-beta.9...v1.7.0-beta.10) (2022-09-27) ### π Features * add data from API to contributors page for hacktoberfest ([#431](open-sauced/app#431)) ([56e12ea](open-sauced/app@56e12ea)), closes [#404](open-sauced/app#404)
## [1.8.0-beta.1](open-sauced/app@v1.7.0...v1.8.0-beta.1) (2022-09-28) ### π Features * add data from API to contributors page for hacktoberfest ([#431](open-sauced/app#431)) ([56e12ea](open-sauced/app@56e12ea)), closes [#404](open-sauced/app#404) * Add truncate string for long pr names ([#440](open-sauced/app#440)) ([35b8541](open-sauced/app@35b8541)), closes [#438](open-sauced/app#438) * adds initial support for restricting reports by user roles ([#451](open-sauced/app#451)) ([15a7643](open-sauced/app@15a7643)), closes [#395](open-sauced/app#395) ### π Bug Fixes * adds links to footer ([#432](open-sauced/app#432)) ([7adfbe7](open-sauced/app@7adfbe7)) * inverse the scatter chart ([#433](open-sauced/app#433)) ([18dd094](open-sauced/app@18dd094)), closes [#399](open-sauced/app#399) * limit number of languages in contibutor's card ([#441](open-sauced/app#441)) ([4aba355](open-sauced/app@4aba355)), closes [#402](open-sauced/app#402) * remove link from highlight card component ([#435](open-sauced/app#435)) ([25b6997](open-sauced/app@25b6997)) * remove remaining mock data for contributors ([#443](open-sauced/app#443)) ([974c739](open-sauced/app@974c739)), closes [#404](open-sauced/app#404) [#444](open-sauced/app#444)
## [1.8.0](open-sauced/app@v1.7.0...v1.8.0) (2022-09-28) ### π Features * add data from API to contributors page for hacktoberfest ([#431](open-sauced/app#431)) ([56e12ea](open-sauced/app@56e12ea)), closes [#404](open-sauced/app#404) * Add truncate string for long pr names ([#440](open-sauced/app#440)) ([35b8541](open-sauced/app@35b8541)), closes [#438](open-sauced/app#438) * adds initial support for restricting reports by user roles ([#451](open-sauced/app#451)) ([15a7643](open-sauced/app@15a7643)), closes [#395](open-sauced/app#395) ### π Bug Fixes * adds links to footer ([#432](open-sauced/app#432)) ([7adfbe7](open-sauced/app@7adfbe7)) * inverse the scatter chart ([#433](open-sauced/app#433)) ([18dd094](open-sauced/app@18dd094)), closes [#399](open-sauced/app#399) * limit number of languages in contibutor's card ([#441](open-sauced/app#441)) ([4aba355](open-sauced/app@4aba355)), closes [#402](open-sauced/app#402) * remove link from highlight card component ([#435](open-sauced/app#435)) ([25b6997](open-sauced/app@25b6997)) * remove remaining mock data for contributors ([#443](open-sauced/app#443)) ([974c739](open-sauced/app@974c739)), closes [#404](open-sauced/app#404) [#444](open-sauced/app#444)
What type of PR is this? (check all applicable)
Description
This PR adds live API data to the contributors page for all repos using the
hacktoberfest
topic.Needs https://github.com/open-sauced/gs-api.opensauced.pizza/pull/27 to be deployedNeeds https://github.com/open-sauced/gs-api.opensauced.pizza/pull/33 to be deployedNeeds https://github.com/open-sauced/gs-api.opensauced.pizza/pull/35 to be merged/deployedNeeds https://github.com/open-sauced/gs-api.opensauced.pizza/pull/37 to be merged/deployedTODO
Related Tickets & Documents
Mobile & Desktop Screenshots/Recordings
Added tests?
Added to documentation?
[optional] Are there any post-deployment tasks we need to perform?
[optional] What gif best describes this PR or how it makes you feel?