Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove remaining mock data for contributors #443

Merged
merged 2 commits into from
Sep 27, 2022

Conversation

brandonroberts
Copy link
Contributor

@brandonroberts brandonroberts commented Sep 27, 2022

What type of PR is this? (check all applicable)

  • πŸ• Feature
  • πŸ› Bug Fix
  • πŸ“ Documentation Update
  • 🎨 Style
  • πŸ§‘β€πŸ’» Code Refactor
  • πŸ”₯ Performance Improvements
  • βœ… Test
  • πŸ€– Build
  • πŸ” CI
  • πŸ“¦ Chore (Release)
  • ⏩ Revert

Description

This PR removes the remaining mock data for contributors. Also updates the "Distance In Days" to return a "-" for 0 days calculated.

Closes #404
Closes #444

Needs https://github.com/open-sauced/gs-api.opensauced.pizza/pull/39 to be merged/deployed

Related Tickets & Documents

Mobile & Desktop Screenshots/Recordings

image

Added tests?

  • πŸ‘ yes
  • πŸ™… no, because they aren't needed
  • πŸ™‹ no, because I need help

Added to documentation?

  • πŸ“œ README.md
  • πŸ““ docs.opensauced.pizza
  • πŸ• dev.to/opensauced
  • πŸ“• storybook
  • πŸ™… no documentation needed

[optional] Are there any post-deployment tasks we need to perform?

[optional] What gif best describes this PR or how it makes you feel?

@netlify
Copy link

netlify bot commented Sep 27, 2022

βœ… Deploy Preview for oss-insights ready!

Name Link
πŸ”¨ Latest commit 765dfc2
πŸ” Latest deploy log https://app.netlify.com/sites/oss-insights/deploys/6333084f8e16280009bf042c
😎 Deploy Preview https://deploy-preview-443--oss-insights.netlify.app
πŸ“± Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Compliance Checks Passed!

@netlify
Copy link

netlify bot commented Sep 27, 2022

βœ… Deploy Preview for design-insights ready!

Name Link
πŸ”¨ Latest commit 765dfc2
πŸ” Latest deploy log https://app.netlify.com/sites/design-insights/deploys/6333084f65642f000aeaccdd
😎 Deploy Preview https://deploy-preview-443--design-insights.netlify.app
πŸ“± Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link
Member

@bdougie bdougie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. This meets my expectations from the issues.

@brandonroberts brandonroberts merged commit 974c739 into beta Sep 27, 2022
@brandonroberts brandonroberts deleted the fix-contributor-mock-data branch September 27, 2022 18:33
github-actions bot pushed a commit that referenced this pull request Sep 27, 2022
## [1.7.0-beta.11](v1.7.0-beta.10...v1.7.0-beta.11) (2022-09-27)

### πŸ› Bug Fixes

* remove remaining mock data for contributors ([#443](#443)) ([974c739](974c739)), closes [#404](#404) [#444](#444)
@github-actions
Copy link

πŸŽ‰ This PR is included in version 1.7.0-beta.11 πŸŽ‰

The release is available on GitHub release

Your semantic-release bot πŸ“¦πŸš€

github-actions bot pushed a commit that referenced this pull request Sep 28, 2022
## [1.8.0-beta.1](v1.7.0...v1.8.0-beta.1) (2022-09-28)

### πŸ• Features

* add data from API to contributors page for hacktoberfest ([#431](#431)) ([56e12ea](56e12ea)), closes [#404](#404)
* Add truncate string for long pr names ([#440](#440)) ([35b8541](35b8541)), closes [#438](#438)
* adds initial support for restricting reports by user roles ([#451](#451)) ([15a7643](15a7643)), closes [#395](#395)

### πŸ› Bug Fixes

* adds links to footer ([#432](#432)) ([7adfbe7](7adfbe7))
* inverse the scatter chart ([#433](#433)) ([18dd094](18dd094)), closes [#399](#399)
* limit number of languages in contibutor's card ([#441](#441)) ([4aba355](4aba355)), closes [#402](#402)
* remove link from highlight card component ([#435](#435)) ([25b6997](25b6997))
* remove remaining mock data for contributors ([#443](#443)) ([974c739](974c739)), closes [#404](#404) [#444](#444)
@github-actions
Copy link

πŸŽ‰ This PR is included in version 1.8.0-beta.1 πŸŽ‰

The release is available on GitHub release

Your semantic-release bot πŸ“¦πŸš€

github-actions bot pushed a commit that referenced this pull request Sep 28, 2022
## [1.8.0](v1.7.0...v1.8.0) (2022-09-28)

### πŸ• Features

* add data from API to contributors page for hacktoberfest ([#431](#431)) ([56e12ea](56e12ea)), closes [#404](#404)
* Add truncate string for long pr names ([#440](#440)) ([35b8541](35b8541)), closes [#438](#438)
* adds initial support for restricting reports by user roles ([#451](#451)) ([15a7643](15a7643)), closes [#395](#395)

### πŸ› Bug Fixes

* adds links to footer ([#432](#432)) ([7adfbe7](7adfbe7))
* inverse the scatter chart ([#433](#433)) ([18dd094](18dd094)), closes [#399](#399)
* limit number of languages in contibutor's card ([#441](#441)) ([4aba355](4aba355)), closes [#402](#402)
* remove link from highlight card component ([#435](#435)) ([25b6997](25b6997))
* remove remaining mock data for contributors ([#443](#443)) ([974c739](974c739)), closes [#404](#404) [#444](#444)
@github-actions
Copy link

πŸŽ‰ This PR is included in version 1.8.0 πŸŽ‰

The release is available on GitHub release

Your semantic-release bot πŸ“¦πŸš€

ElpisHelle added a commit to ElpisHelle/next.js-tailwindcss that referenced this pull request Aug 17, 2023
## [1.7.0-beta.11](open-sauced/app@v1.7.0-beta.10...v1.7.0-beta.11) (2022-09-27)

### πŸ› Bug Fixes

* remove remaining mock data for contributors ([#443](open-sauced/app#443)) ([974c739](open-sauced/app@974c739)), closes [#404](open-sauced/app#404) [#444](open-sauced/app#444)
ElpisHelle added a commit to ElpisHelle/next.js-tailwindcss that referenced this pull request Aug 17, 2023
## [1.8.0-beta.1](open-sauced/app@v1.7.0...v1.8.0-beta.1) (2022-09-28)

### πŸ• Features

* add data from API to contributors page for hacktoberfest ([#431](open-sauced/app#431)) ([56e12ea](open-sauced/app@56e12ea)), closes [#404](open-sauced/app#404)
* Add truncate string for long pr names ([#440](open-sauced/app#440)) ([35b8541](open-sauced/app@35b8541)), closes [#438](open-sauced/app#438)
* adds initial support for restricting reports by user roles ([#451](open-sauced/app#451)) ([15a7643](open-sauced/app@15a7643)), closes [#395](open-sauced/app#395)

### πŸ› Bug Fixes

* adds links to footer ([#432](open-sauced/app#432)) ([7adfbe7](open-sauced/app@7adfbe7))
* inverse the scatter chart ([#433](open-sauced/app#433)) ([18dd094](open-sauced/app@18dd094)), closes [#399](open-sauced/app#399)
* limit number of languages in contibutor's card ([#441](open-sauced/app#441)) ([4aba355](open-sauced/app@4aba355)), closes [#402](open-sauced/app#402)
* remove link from highlight card component ([#435](open-sauced/app#435)) ([25b6997](open-sauced/app@25b6997))
* remove remaining mock data for contributors ([#443](open-sauced/app#443)) ([974c739](open-sauced/app@974c739)), closes [#404](open-sauced/app#404) [#444](open-sauced/app#444)
ElpisHelle added a commit to ElpisHelle/next.js-tailwindcss that referenced this pull request Aug 17, 2023
## [1.8.0](open-sauced/app@v1.7.0...v1.8.0) (2022-09-28)

### πŸ• Features

* add data from API to contributors page for hacktoberfest ([#431](open-sauced/app#431)) ([56e12ea](open-sauced/app@56e12ea)), closes [#404](open-sauced/app#404)
* Add truncate string for long pr names ([#440](open-sauced/app#440)) ([35b8541](open-sauced/app@35b8541)), closes [#438](open-sauced/app#438)
* adds initial support for restricting reports by user roles ([#451](open-sauced/app#451)) ([15a7643](open-sauced/app@15a7643)), closes [#395](open-sauced/app#395)

### πŸ› Bug Fixes

* adds links to footer ([#432](open-sauced/app#432)) ([7adfbe7](open-sauced/app@7adfbe7))
* inverse the scatter chart ([#433](open-sauced/app#433)) ([18dd094](open-sauced/app@18dd094)), closes [#399](open-sauced/app#399)
* limit number of languages in contibutor's card ([#441](open-sauced/app#441)) ([4aba355](open-sauced/app@4aba355)), closes [#402](open-sauced/app#402)
* remove link from highlight card component ([#435](open-sauced/app#435)) ([25b6997](open-sauced/app@25b6997))
* remove remaining mock data for contributors ([#443](open-sauced/app#443)) ([974c739](open-sauced/app@974c739)), closes [#404](open-sauced/app#404) [#444](open-sauced/app#444)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

refactor: use swr instead of custom fetching from the API feature: connecting all data for contributor pages
2 participants