Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add Images to Scatter Chart #257

Merged
merged 2 commits into from
Aug 23, 2022

Conversation

chadstewart
Copy link
Contributor

@chadstewart chadstewart commented Aug 23, 2022

What type of PR is this? (check all applicable)

  • πŸ• Feature
  • πŸ› Bug Fix
  • πŸ“ Documentation Update
  • 🎨 Style
  • πŸ§‘β€πŸ’» Code Refactor
  • πŸ”₯ Performance Improvements
  • βœ… Test
  • πŸ€– Build
  • πŸ” CI
  • πŸ“¦ Chore (Release)
  • ⏩ Revert

Description

This PR adds the feature of adding images to the eChart Scatter Chart

Details:

There are two ways to add images to the eChart Scatter Chart:

Related Tickets & Documents

Fixes #97

Mobile & Desktop Screenshots/Recordings

deploy-preview-257--design-insights netlify app__path=_story_design-system-molecules-scatter-chart--with-images

Added tests?

  • πŸ‘ yes
  • πŸ™… no, because they aren't needed
  • πŸ™‹ no, because I need help

Added to documentation?

  • πŸ“œ README.md
  • πŸ““ docs.opensauced.pizza
  • πŸ• dev.to/opensauced
  • πŸ“• storybook
  • πŸ™… no documentation needed

[optional] Are there any post-deployment tasks we need to perform?

[optional] What gif best describes this PR or how it makes you feel?

@netlify
Copy link

netlify bot commented Aug 23, 2022

βœ… Deploy Preview for oss-insights ready!

Name Link
πŸ”¨ Latest commit f680485
πŸ” Latest deploy log https://app.netlify.com/sites/oss-insights/deploys/63051e81e56f2200099ee871
😎 Deploy Preview https://deploy-preview-257--oss-insights.netlify.app
πŸ“± Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Aug 23, 2022

βœ… Deploy Preview for design-insights ready!

Name Link
πŸ”¨ Latest commit f680485
πŸ” Latest deploy log https://app.netlify.com/sites/design-insights/deploys/63051e81c3c9b40008114a50
😎 Deploy Preview https://deploy-preview-257--design-insights.netlify.app
πŸ“± Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@chadstewart chadstewart marked this pull request as ready for review August 23, 2022 18:44
Copy link
Contributor

@0-vortex 0-vortex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! πŸ‘

Copy link
Member

@bdougie bdougie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a screenshot when you have a moment.

@chadstewart chadstewart merged commit 20df419 into beta Aug 23, 2022
@chadstewart chadstewart deleted the 97-replace-echart-dots-with-images branch August 23, 2022 20:16
github-actions bot pushed a commit that referenced this pull request Aug 23, 2022
## [1.3.0-beta.7](v1.3.0-beta.6...v1.3.0-beta.7) (2022-08-23)

### πŸ• Features

* Add Images to Scatter Chart ([#257](#257)) ([20df419](20df419))
* Add item count meta data to Highlight Card ([#254](#254)) ([693479e](693479e))
@github-actions
Copy link
Contributor

πŸŽ‰ This PR is included in version 1.3.0-beta.7 πŸŽ‰

The release is available on GitHub release

Your semantic-release bot πŸ“¦πŸš€

github-actions bot pushed a commit that referenced this pull request Aug 29, 2022
## [1.3.0](v1.2.3...v1.3.0) (2022-08-29)

### πŸ§‘β€πŸ’» Code Refactoring

* Improve the `<ComponentCard>` CSS ([#266](#266)) ([9da4d62](9da4d62))
* Make the avatar component accept custom sizes ([#255](#255)) ([9076e91](9076e91)), closes [#235](#235)

### πŸ• Features

* Add Images to Scatter Chart ([#257](#257)) ([20df419](20df419))
* Add item count meta data to Highlight Card ([#254](#254)) ([693479e](693479e))
* Added Reports History component to Reports Page ([#272](#272)) ([c6a56f6](c6a56f6))
* Implement Card Horizontal Bar component ([#237](#237)) ([7bbbe40](7bbbe40))
* Implement Card Table Component ([#243](#243)) ([0cbc6ea](0cbc6ea))
* Implement contribution page ([#263](#263)) ([f41d7f9](f41d7f9))
* Implement Contributor Card Component ([#245](#245)) ([3bd55ea](3bd55ea))
* Implement Reports History Component ([#209](#209)) ([bb531e4](bb531e4))
* Implement the hacktoberfest reports page ([#229](#229)) ([0cfa5e5](0cfa5e5)), closes [#168](#168)
* Implement waitlist page ([#210](#210)) ([0826d07](0826d07)), closes [#152](#152)

### πŸ› Bug Fixes

* adjusted opinion filter on mobile screens ([#264](#264)) ([2d9785c](2d9785c))
* correct login redirect issues in supabase implemetation ([#274](#274)) ([8fcd81e](8fcd81e))
* correct login redirect issues in supabase implemetation x2 ([#275](#275)) ([0239abd](0239abd))
* correct supabase-ui default style for hover ([#267](#267)) ([a23fe4b](a23fe4b)), closes [#226](#226)
* increase truncate string number of words ([#268](#268)) ([ab47a96](ab47a96)), closes [#247](#247)
* max width removed from card ([#250](#250)) ([523969a](523969a)), closes [#249](#249)
* removes unused function ([b37de35](b37de35))
* Repo count ([#244](#244)) ([d59eef8](d59eef8))
* Update GitSense API route for repos ([#270](#270)) ([8f7e1c5](8f7e1c5))
@github-actions
Copy link
Contributor

πŸŽ‰ This PR is included in version 1.3.0 πŸŽ‰

The release is available on GitHub release

Your semantic-release bot πŸ“¦πŸš€

ElpisHelle added a commit to ElpisHelle/next.js-tailwindcss that referenced this pull request Aug 17, 2023
## [1.3.0-beta.7](open-sauced/app@v1.3.0-beta.6...v1.3.0-beta.7) (2022-08-23)

### πŸ• Features

* Add Images to Scatter Chart ([#257](open-sauced/app#257)) ([20df419](open-sauced/app@20df419))
* Add item count meta data to Highlight Card ([#254](open-sauced/app#254)) ([693479e](open-sauced/app@693479e))
ElpisHelle added a commit to ElpisHelle/next.js-tailwindcss that referenced this pull request Aug 17, 2023
## [1.3.0](open-sauced/app@v1.2.3...v1.3.0) (2022-08-29)

### πŸ§‘β€πŸ’» Code Refactoring

* Improve the `<ComponentCard>` CSS ([#266](open-sauced/app#266)) ([9da4d62](open-sauced/app@9da4d62))
* Make the avatar component accept custom sizes ([#255](open-sauced/app#255)) ([9076e91](open-sauced/app@9076e91)), closes [#235](open-sauced/app#235)

### πŸ• Features

* Add Images to Scatter Chart ([#257](open-sauced/app#257)) ([20df419](open-sauced/app@20df419))
* Add item count meta data to Highlight Card ([#254](open-sauced/app#254)) ([693479e](open-sauced/app@693479e))
* Added Reports History component to Reports Page ([#272](open-sauced/app#272)) ([c6a56f6](open-sauced/app@c6a56f6))
* Implement Card Horizontal Bar component ([#237](open-sauced/app#237)) ([7bbbe40](open-sauced/app@7bbbe40))
* Implement Card Table Component ([#243](open-sauced/app#243)) ([0cbc6ea](open-sauced/app@0cbc6ea))
* Implement contribution page ([#263](open-sauced/app#263)) ([f41d7f9](open-sauced/app@f41d7f9))
* Implement Contributor Card Component ([#245](open-sauced/app#245)) ([3bd55ea](open-sauced/app@3bd55ea))
* Implement Reports History Component ([#209](open-sauced/app#209)) ([bb531e4](open-sauced/app@bb531e4))
* Implement the hacktoberfest reports page ([#229](open-sauced/app#229)) ([0cfa5e5](open-sauced/app@0cfa5e5)), closes [#168](open-sauced/app#168)
* Implement waitlist page ([#210](open-sauced/app#210)) ([0826d07](open-sauced/app@0826d07)), closes [#152](open-sauced/app#152)

### πŸ› Bug Fixes

* adjusted opinion filter on mobile screens ([#264](open-sauced/app#264)) ([2d9785c](open-sauced/app@2d9785c))
* correct login redirect issues in supabase implemetation ([#274](open-sauced/app#274)) ([8fcd81e](open-sauced/app@8fcd81e))
* correct login redirect issues in supabase implemetation x2 ([#275](open-sauced/app#275)) ([0239abd](open-sauced/app@0239abd))
* correct supabase-ui default style for hover ([#267](open-sauced/app#267)) ([a23fe4b](open-sauced/app@a23fe4b)), closes [#226](open-sauced/app#226)
* increase truncate string number of words ([#268](open-sauced/app#268)) ([ab47a96](open-sauced/app@ab47a96)), closes [#247](open-sauced/app#247)
* max width removed from card ([#250](open-sauced/app#250)) ([523969a](open-sauced/app@523969a)), closes [#249](open-sauced/app#249)
* removes unused function ([b37de35](open-sauced/app@b37de35))
* Repo count ([#244](open-sauced/app#244)) ([d59eef8](open-sauced/app@d59eef8))
* Update GitSense API route for repos ([#270](open-sauced/app#270)) ([8f7e1c5](open-sauced/app@8f7e1c5))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants