refactor: Improve the `<ComponentCard>` CSS #266

eryc-cc · 2022-08-25T18:18:44Z

What type of PR is this? (check all applicable)

Description

This PR:

Removes extra padding
Fixes gaps between components
Updates eCharts (yes, we will replace it, but it can look better in the meantime)
Fixes alignment between components

Related Tickets & Documents

Fixes #265

Mobile & Desktop Screenshots/Recordings

Currently:

Added tests?

👍 yes
🙅 no, because they aren't needed
🙋 no, because I need help

Added to documentation?

[optional] Are there any post-deployment tasks we need to perform?

[optional] What gif best describes this PR or how it makes you feel?

…ate gap

…file>`

…r Card data

…`<ContributorTable>`

netlify · 2022-08-25T18:18:48Z

✅ Deploy Preview for oss-insights ready!

Name	Link
🔨 Latest commit	`1773f52`
🔍 Latest deploy log	https://app.netlify.com/sites/oss-insights/deploys/6307c0555cbe9d000814910b
😎 Deploy Preview	https://deploy-preview-266--oss-insights.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

netlify · 2022-08-25T18:20:19Z

✅ Deploy Preview for design-insights ready!

Name	Link
🔨 Latest commit	`1773f52`
🔍 Latest deploy log	https://app.netlify.com/sites/design-insights/deploys/6307c0558b5c570009a760d3
😎 Deploy Preview	https://deploy-preview-266--design-insights.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

0-vortex

LGTM! 👍

lib/hooks/useContributorData.ts

eryc-cc · 2022-08-25T18:34:26Z

@chadstewart @sungoldtech

Please take a closer look... I made changes to most of the components you shipped 🙏

Let me know if you find anything that shouldn't be there

OgDev-01 · 2022-08-25T18:55:24Z

@chadstewart @sungoldtech

Please take a closer look... I made changes to most of the components you shipped 🙏

Let me know if you find anything that shouldn't be there

LGTM in general 🍕🍕

chadstewart

LGTM!

eryc-cc · 2022-08-25T21:04:50Z

@0-vortex @bdougie

Do I "Squash and merge" or "create a merge commit"?

eryc-cc · 2022-08-25T21:05:04Z

@0-vortex @bdougie

Do I "Squash and merge" or "create a merge commit"?

bdougie · 2022-08-25T21:05:33Z

Squash 😀

0-vortex · 2022-08-25T21:06:12Z

Like that! 🍕

chadstewart · 2022-08-25T21:16:24Z

Like that! pizza

@pixelsbyeryc, not sure if you wrote that yourself but when I squash and merge, I don't write anything into the commit message. Whatever is in the dialog box I leave and just hit the squash and merge button.

0-vortex · 2022-08-25T22:20:39Z

Like that! pizza

@pixelsbyeryc, not sure if you wrote that yourself but when I squash and merge, I don't write anything into the commit message. Whatever is in the dialog box I leave and just hit the squash and merge button.

That is very wrong, you need to manually ensure the closes #ticketNo message is in there, hence the screenshot. If you don't do that, you get a commit message that can make more issue messages than intended, because they squash the commit messages of the incoming branch; the purpose of the squash is that those messages DO NOT get into the commit history and produce a nice friendly message from the PR title.

bad @chadstewart !!! 🍕

0-vortex · 2022-08-25T22:23:50Z

To recap this:

Should be:

that is the price of loyalty 👯‍♂️ 👯‍♀️

## [1.3.0-beta.12](v1.3.0-beta.11...v1.3.0-beta.12) (2022-08-25) ### 🧑‍💻 Code Refactoring * Improve the `<ComponentCard>` CSS ([#266](#266)) ([9da4d62](9da4d62))

github-actions · 2022-08-25T23:55:53Z

🎉 This PR is included in version 1.3.0-beta.12 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

## [1.3.0](v1.2.3...v1.3.0) (2022-08-29) ### 🧑‍💻 Code Refactoring * Improve the `<ComponentCard>` CSS ([#266](#266)) ([9da4d62](9da4d62)) * Make the avatar component accept custom sizes ([#255](#255)) ([9076e91](9076e91)), closes [#235](#235) ### 🍕 Features * Add Images to Scatter Chart ([#257](#257)) ([20df419](20df419)) * Add item count meta data to Highlight Card ([#254](#254)) ([693479e](693479e)) * Added Reports History component to Reports Page ([#272](#272)) ([c6a56f6](c6a56f6)) * Implement Card Horizontal Bar component ([#237](#237)) ([7bbbe40](7bbbe40)) * Implement Card Table Component ([#243](#243)) ([0cbc6ea](0cbc6ea)) * Implement contribution page ([#263](#263)) ([f41d7f9](f41d7f9)) * Implement Contributor Card Component ([#245](#245)) ([3bd55ea](3bd55ea)) * Implement Reports History Component ([#209](#209)) ([bb531e4](bb531e4)) * Implement the hacktoberfest reports page ([#229](#229)) ([0cfa5e5](0cfa5e5)), closes [#168](#168) * Implement waitlist page ([#210](#210)) ([0826d07](0826d07)), closes [#152](#152) ### 🐛 Bug Fixes * adjusted opinion filter on mobile screens ([#264](#264)) ([2d9785c](2d9785c)) * correct login redirect issues in supabase implemetation ([#274](#274)) ([8fcd81e](8fcd81e)) * correct login redirect issues in supabase implemetation x2 ([#275](#275)) ([0239abd](0239abd)) * correct supabase-ui default style for hover ([#267](#267)) ([a23fe4b](a23fe4b)), closes [#226](#226) * increase truncate string number of words ([#268](#268)) ([ab47a96](ab47a96)), closes [#247](#247) * max width removed from card ([#250](#250)) ([523969a](523969a)), closes [#249](#249) * removes unused function ([b37de35](b37de35)) * Repo count ([#244](#244)) ([d59eef8](d59eef8)) * Update GitSense API route for repos ([#270](#270)) ([8f7e1c5](8f7e1c5))

github-actions · 2022-08-29T19:52:59Z

🎉 This PR is included in version 1.3.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

## [1.3.0-beta.12](open-sauced/app@v1.3.0-beta.11...v1.3.0-beta.12) (2022-08-25) ### 🧑‍💻 Code Refactoring * Improve the `<ComponentCard>` CSS ([#266](open-sauced/app#266)) ([9da4d62](open-sauced/app@9da4d62))

## [1.3.0](open-sauced/app@v1.2.3...v1.3.0) (2022-08-29) ### 🧑‍💻 Code Refactoring * Improve the `<ComponentCard>` CSS ([#266](open-sauced/app#266)) ([9da4d62](open-sauced/app@9da4d62)) * Make the avatar component accept custom sizes ([#255](open-sauced/app#255)) ([9076e91](open-sauced/app@9076e91)), closes [#235](open-sauced/app#235) ### 🍕 Features * Add Images to Scatter Chart ([#257](open-sauced/app#257)) ([20df419](open-sauced/app@20df419)) * Add item count meta data to Highlight Card ([#254](open-sauced/app#254)) ([693479e](open-sauced/app@693479e)) * Added Reports History component to Reports Page ([#272](open-sauced/app#272)) ([c6a56f6](open-sauced/app@c6a56f6)) * Implement Card Horizontal Bar component ([#237](open-sauced/app#237)) ([7bbbe40](open-sauced/app@7bbbe40)) * Implement Card Table Component ([#243](open-sauced/app#243)) ([0cbc6ea](open-sauced/app@0cbc6ea)) * Implement contribution page ([#263](open-sauced/app#263)) ([f41d7f9](open-sauced/app@f41d7f9)) * Implement Contributor Card Component ([#245](open-sauced/app#245)) ([3bd55ea](open-sauced/app@3bd55ea)) * Implement Reports History Component ([#209](open-sauced/app#209)) ([bb531e4](open-sauced/app@bb531e4)) * Implement the hacktoberfest reports page ([#229](open-sauced/app#229)) ([0cfa5e5](open-sauced/app@0cfa5e5)), closes [#168](open-sauced/app#168) * Implement waitlist page ([#210](open-sauced/app#210)) ([0826d07](open-sauced/app@0826d07)), closes [#152](open-sauced/app#152) ### 🐛 Bug Fixes * adjusted opinion filter on mobile screens ([#264](open-sauced/app#264)) ([2d9785c](open-sauced/app@2d9785c)) * correct login redirect issues in supabase implemetation ([#274](open-sauced/app#274)) ([8fcd81e](open-sauced/app@8fcd81e)) * correct login redirect issues in supabase implemetation x2 ([#275](open-sauced/app#275)) ([0239abd](open-sauced/app@0239abd)) * correct supabase-ui default style for hover ([#267](open-sauced/app#267)) ([a23fe4b](open-sauced/app@a23fe4b)), closes [#226](open-sauced/app#226) * increase truncate string number of words ([#268](open-sauced/app#268)) ([ab47a96](open-sauced/app@ab47a96)), closes [#247](open-sauced/app#247) * max width removed from card ([#250](open-sauced/app#250)) ([523969a](open-sauced/app@523969a)), closes [#249](open-sauced/app#249) * removes unused function ([b37de35](open-sauced/app@b37de35)) * Repo count ([#244](open-sauced/app#244)) ([d59eef8](open-sauced/app@d59eef8)) * Update GitSense API route for repos ([#270](open-sauced/app#270)) ([8f7e1c5](open-sauced/app@8f7e1c5))

eryc-cc added 11 commits August 25, 2022 15:04

style: Reduce internal padding from <Card> component

1532e60

style: Set <CardNHorizontalBarChart> width in the component and upd…

a264c09

…ate gap

style: Update <ContributorCard> gap and alignment

1c2922a

style: Remove margin-top and update gap on <CardHorizontalBarChart>

053d7fe

style: Set a custom width for the <ContributorProfile> Avatar

a9f747c

style: Fix alignment, spacing, and font sizes in `<ContributorCardPro…

a56124c

…file>`

refactor: Remove axisLabel from Contributor Card

13b0861

refactor: Remove internal padding, and set fixed height in Contributo…

6933cd5

…r Card data

style: Add fixed height to <CardLineChart> and remove padding from …

85310d2

…`<ContributorTable>`

style: Remove padding from <ContributorCard> button

4d379ac

refactor: Re-structure <ContributorTable> within sectioned divs.

552ca8b

eryc-cc self-assigned this Aug 25, 2022

eryc-cc requested review from bdougie, OgDev-01 and chadstewart and removed request for bdougie and OgDev-01 August 25, 2022 18:18

eryc-cc added the 🍕 enhancement New feature or request label Aug 25, 2022

eryc-cc marked this pull request as ready for review August 25, 2022 18:19

eryc-cc added this to the Hacktoberfest Ready - Week 34 milestone Aug 25, 2022

eryc-cc added 2 commits August 25, 2022 15:25

style: Round the repository image

3b98e24

refactor: Fix issue where the lineChart was above the CardTable

ccef7b5

eryc-cc added the needs review PRs that need review from core engineering team label Aug 25, 2022

0-vortex approved these changes Aug 25, 2022

View reviewed changes

lib/hooks/useContributorData.ts Outdated Show resolved Hide resolved

style: Add space

1773f52

eryc-cc mentioned this pull request Aug 25, 2022

TOP 5 Week 34 August 22nd #251

Closed

OgDev-01 approved these changes Aug 25, 2022

View reviewed changes

chadstewart approved these changes Aug 25, 2022

View reviewed changes

eryc-cc merged commit 9da4d62 into beta Aug 25, 2022

eryc-cc deleted the 256-improve-component-card-css branch August 25, 2022 23:52

github-actions bot added the released on @beta label Aug 25, 2022

eryc-cc mentioned this pull request Aug 25, 2022

feat: Update Scatter Chart Legend #260

Merged

19 tasks

github-actions bot added the released label Aug 29, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

refactor: Improve the `<ComponentCard>` CSS #266

refactor: Improve the `<ComponentCard>` CSS #266

eryc-cc commented Aug 25, 2022

netlify bot commented Aug 25, 2022 •

edited

Loading

netlify bot commented Aug 25, 2022 •

edited

Loading

0-vortex left a comment

eryc-cc commented Aug 25, 2022 •

edited

Loading

OgDev-01 commented Aug 25, 2022

chadstewart left a comment

eryc-cc commented Aug 25, 2022

eryc-cc commented Aug 25, 2022

bdougie commented Aug 25, 2022

0-vortex commented Aug 25, 2022

chadstewart commented Aug 25, 2022

0-vortex commented Aug 25, 2022

0-vortex commented Aug 25, 2022

github-actions bot commented Aug 25, 2022

github-actions bot commented Aug 29, 2022

refactor: Improve the <ComponentCard> CSS #266

refactor: Improve the <ComponentCard> CSS #266

Conversation

eryc-cc commented Aug 25, 2022

What type of PR is this? (check all applicable)

Description

Related Tickets & Documents

Mobile & Desktop Screenshots/Recordings

Currently:

Previous:

Added tests?

Added to documentation?

[optional] Are there any post-deployment tasks we need to perform?

[optional] What gif best describes this PR or how it makes you feel?

netlify bot commented Aug 25, 2022 • edited Loading

✅ Deploy Preview for oss-insights ready!

netlify bot commented Aug 25, 2022 • edited Loading

✅ Deploy Preview for design-insights ready!

0-vortex left a comment

Choose a reason for hiding this comment

eryc-cc commented Aug 25, 2022 • edited Loading

OgDev-01 commented Aug 25, 2022

chadstewart left a comment

Choose a reason for hiding this comment

eryc-cc commented Aug 25, 2022

eryc-cc commented Aug 25, 2022

bdougie commented Aug 25, 2022

0-vortex commented Aug 25, 2022

chadstewart commented Aug 25, 2022

0-vortex commented Aug 25, 2022

0-vortex commented Aug 25, 2022

github-actions bot commented Aug 25, 2022

github-actions bot commented Aug 29, 2022

refactor: Improve the `<ComponentCard>` CSS #266

refactor: Improve the `<ComponentCard>` CSS #266

netlify bot commented Aug 25, 2022 •

edited

Loading

netlify bot commented Aug 25, 2022 •

edited

Loading

eryc-cc commented Aug 25, 2022 •

edited

Loading