Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Implement waitlist page #210

Merged
merged 19 commits into from
Aug 26, 2022
Merged

feat: Implement waitlist page #210

merged 19 commits into from
Aug 26, 2022

Conversation

OgDev-01
Copy link
Contributor

@OgDev-01 OgDev-01 commented Aug 16, 2022

What type of PR is this? (check all applicable)

  • πŸ• Feature
  • πŸ› Bug Fix
  • πŸ“ Documentation Update
  • 🎨 Style
  • πŸ§‘β€πŸ’» Code Refactor
  • πŸ”₯ Performance Improvements
  • βœ… Test
  • πŸ€– Build
  • πŸ” CI
  • πŸ“¦ Chore (Release)
  • ⏩ Revert

Description

This PR implements a waitlist component draft, which is still incomplete though. I made some updates to the tailwind.config.js file to incorporate the radial gradient color variable and also added a custom blur size, Go back home button still has the wrong icon as I haven't gotten a good match to what we have in the design, created ComponentGradient to house the gradient background. Also made the AvatarRoll component reusable.

Related Tickets & Documents

Fix #152

Mobile & Desktop Screenshots/Recordings

AvatarRoll component molecules
Screenshot (43)

ComponentGradient component molecules

Screenshot (44)

ComponentWaitlist component organisms

Screenshot (45)

Added tests?

  • πŸ‘ yes
  • πŸ™… no, because they aren't needed
  • πŸ™‹ no, because I need help

Added to documentation?

  • πŸ“œ README.md
  • πŸ““ docs.opensauced.pizza
  • πŸ• dev.to/opensauced
  • πŸ“• storybook
  • πŸ™… no documentation needed

[optional] Are there any post-deployment tasks we need to perform?

[optional] What gif best describes this PR or how it makes you feel?

@netlify
Copy link

netlify bot commented Aug 16, 2022

βœ… Deploy Preview for design-insights ready!

Name Link
πŸ”¨ Latest commit 09e0f83
πŸ” Latest deploy log https://app.netlify.com/sites/design-insights/deploys/6309055444f32c0009ac1b75
😎 Deploy Preview https://deploy-preview-210--design-insights.netlify.app
πŸ“± Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Aug 16, 2022

βœ… Deploy Preview for oss-insights ready!

Name Link
πŸ”¨ Latest commit 09e0f83
πŸ” Latest deploy log https://app.netlify.com/sites/oss-insights/deploys/6309055300fbed00096949de
😎 Deploy Preview https://deploy-preview-210--oss-insights.netlify.app
πŸ“± Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@OgDev-01 OgDev-01 marked this pull request as ready for review August 16, 2022 17:46
@chadstewart
Copy link
Contributor

Quick question @sungoldtech. I know you marked it this as ready for review but I just wanted to make sure it was because you still have draft in the title.

Copy link
Contributor

@0-vortex 0-vortex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a couple of changes regarding type safety (tooling), LGTM otherwise! πŸ‘

components/molecules/AvatarRoll/avatar-roll.tsx Outdated Show resolved Hide resolved
@@ -0,0 +1,9 @@
import ComponentWaitlist from "components/organisms/ComponentWaitlist/component-waitlist";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we move it into pages instead of organisms? cc @chadstewart

Copy link
Contributor

@eryc-cc eryc-cc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think these sum the design changes. Nice work so far, @sungoldtech!

@0-vortex
Copy link
Contributor

LGTM now but we have some PRs against main and some against beta - IMHO it should be beta, right? :D

@OgDev-01
Copy link
Contributor Author

LGTM now but we have some PRs against main and some against beta - IMHO it should be beta, right? :D

Sure @0-vortex , I'm changing the base branch right away to beta

Thanks for your support so far πŸ™Œ
I'm grateful βœ”

@OgDev-01 OgDev-01 changed the base branch from main to beta August 18, 2022 12:59
@chadstewart chadstewart changed the title feat: implement waitlist page draft version feat: Implement waitlist page Aug 18, 2022
Copy link
Member

@bdougie bdougie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sungoldtech could you rename this from "ComponentWaitlist" to just "Waitlist"

@OgDev-01
Copy link
Contributor Author

@sungoldtech could you rename this from "ComponentWaitlist" to just "Waitlist"

Sure, on it now πŸ‘Œ

@bdougie bdougie merged commit 0826d07 into beta Aug 26, 2022
@bdougie bdougie deleted the implement-waiting-list-page branch August 26, 2022 17:44
github-actions bot pushed a commit that referenced this pull request Aug 26, 2022
## [1.3.0-beta.15](v1.3.0-beta.14...v1.3.0-beta.15) (2022-08-26)

### πŸ• Features

* Implement waitlist page ([#210](#210)) ([0826d07](0826d07)), closes [#152](#152)
@github-actions
Copy link
Contributor

πŸŽ‰ This PR is included in version 1.3.0-beta.15 πŸŽ‰

The release is available on GitHub release

Your semantic-release bot πŸ“¦πŸš€

github-actions bot pushed a commit that referenced this pull request Aug 29, 2022
## [1.3.0](v1.2.3...v1.3.0) (2022-08-29)

### πŸ§‘β€πŸ’» Code Refactoring

* Improve the `<ComponentCard>` CSS ([#266](#266)) ([9da4d62](9da4d62))
* Make the avatar component accept custom sizes ([#255](#255)) ([9076e91](9076e91)), closes [#235](#235)

### πŸ• Features

* Add Images to Scatter Chart ([#257](#257)) ([20df419](20df419))
* Add item count meta data to Highlight Card ([#254](#254)) ([693479e](693479e))
* Added Reports History component to Reports Page ([#272](#272)) ([c6a56f6](c6a56f6))
* Implement Card Horizontal Bar component ([#237](#237)) ([7bbbe40](7bbbe40))
* Implement Card Table Component ([#243](#243)) ([0cbc6ea](0cbc6ea))
* Implement contribution page ([#263](#263)) ([f41d7f9](f41d7f9))
* Implement Contributor Card Component ([#245](#245)) ([3bd55ea](3bd55ea))
* Implement Reports History Component ([#209](#209)) ([bb531e4](bb531e4))
* Implement the hacktoberfest reports page ([#229](#229)) ([0cfa5e5](0cfa5e5)), closes [#168](#168)
* Implement waitlist page ([#210](#210)) ([0826d07](0826d07)), closes [#152](#152)

### πŸ› Bug Fixes

* adjusted opinion filter on mobile screens ([#264](#264)) ([2d9785c](2d9785c))
* correct login redirect issues in supabase implemetation ([#274](#274)) ([8fcd81e](8fcd81e))
* correct login redirect issues in supabase implemetation x2 ([#275](#275)) ([0239abd](0239abd))
* correct supabase-ui default style for hover ([#267](#267)) ([a23fe4b](a23fe4b)), closes [#226](#226)
* increase truncate string number of words ([#268](#268)) ([ab47a96](ab47a96)), closes [#247](#247)
* max width removed from card ([#250](#250)) ([523969a](523969a)), closes [#249](#249)
* removes unused function ([b37de35](b37de35))
* Repo count ([#244](#244)) ([d59eef8](d59eef8))
* Update GitSense API route for repos ([#270](#270)) ([8f7e1c5](8f7e1c5))
@github-actions
Copy link
Contributor

πŸŽ‰ This PR is included in version 1.3.0 πŸŽ‰

The release is available on GitHub release

Your semantic-release bot πŸ“¦πŸš€

ElpisHelle added a commit to ElpisHelle/next.js-tailwindcss that referenced this pull request Aug 17, 2023
## [1.3.0-beta.15](open-sauced/app@v1.3.0-beta.14...v1.3.0-beta.15) (2022-08-26)

### πŸ• Features

* Implement waitlist page ([#210](open-sauced/app#210)) ([0826d07](open-sauced/app@0826d07)), closes [#152](open-sauced/app#152)
ElpisHelle added a commit to ElpisHelle/next.js-tailwindcss that referenced this pull request Aug 17, 2023
## [1.3.0](open-sauced/app@v1.2.3...v1.3.0) (2022-08-29)

### πŸ§‘β€πŸ’» Code Refactoring

* Improve the `<ComponentCard>` CSS ([#266](open-sauced/app#266)) ([9da4d62](open-sauced/app@9da4d62))
* Make the avatar component accept custom sizes ([#255](open-sauced/app#255)) ([9076e91](open-sauced/app@9076e91)), closes [#235](open-sauced/app#235)

### πŸ• Features

* Add Images to Scatter Chart ([#257](open-sauced/app#257)) ([20df419](open-sauced/app@20df419))
* Add item count meta data to Highlight Card ([#254](open-sauced/app#254)) ([693479e](open-sauced/app@693479e))
* Added Reports History component to Reports Page ([#272](open-sauced/app#272)) ([c6a56f6](open-sauced/app@c6a56f6))
* Implement Card Horizontal Bar component ([#237](open-sauced/app#237)) ([7bbbe40](open-sauced/app@7bbbe40))
* Implement Card Table Component ([#243](open-sauced/app#243)) ([0cbc6ea](open-sauced/app@0cbc6ea))
* Implement contribution page ([#263](open-sauced/app#263)) ([f41d7f9](open-sauced/app@f41d7f9))
* Implement Contributor Card Component ([#245](open-sauced/app#245)) ([3bd55ea](open-sauced/app@3bd55ea))
* Implement Reports History Component ([#209](open-sauced/app#209)) ([bb531e4](open-sauced/app@bb531e4))
* Implement the hacktoberfest reports page ([#229](open-sauced/app#229)) ([0cfa5e5](open-sauced/app@0cfa5e5)), closes [#168](open-sauced/app#168)
* Implement waitlist page ([#210](open-sauced/app#210)) ([0826d07](open-sauced/app@0826d07)), closes [#152](open-sauced/app#152)

### πŸ› Bug Fixes

* adjusted opinion filter on mobile screens ([#264](open-sauced/app#264)) ([2d9785c](open-sauced/app@2d9785c))
* correct login redirect issues in supabase implemetation ([#274](open-sauced/app#274)) ([8fcd81e](open-sauced/app@8fcd81e))
* correct login redirect issues in supabase implemetation x2 ([#275](open-sauced/app#275)) ([0239abd](open-sauced/app@0239abd))
* correct supabase-ui default style for hover ([#267](open-sauced/app#267)) ([a23fe4b](open-sauced/app@a23fe4b)), closes [#226](open-sauced/app#226)
* increase truncate string number of words ([#268](open-sauced/app#268)) ([ab47a96](open-sauced/app@ab47a96)), closes [#247](open-sauced/app#247)
* max width removed from card ([#250](open-sauced/app#250)) ([523969a](open-sauced/app@523969a)), closes [#249](open-sauced/app#249)
* removes unused function ([b37de35](open-sauced/app@b37de35))
* Repo count ([#244](open-sauced/app#244)) ([d59eef8](open-sauced/app@d59eef8))
* Update GitSense API route for repos ([#270](open-sauced/app#270)) ([8f7e1c5](open-sauced/app@8f7e1c5))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Front-End] Implement "Waiting List" Page
5 participants