Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fixed star search URL for SEO #3218

Merged
merged 1 commit into from
Apr 17, 2024
Merged

fix: fixed star search URL for SEO #3218

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions components/organisms/TopNav/top-nav.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,9 +89,9 @@ const Nav = ({ className }: { className?: string }) => {
<li className="hidden lg:inline">
<Link
className={`tracking-tight font-medium text-sm text-slate-700 hover:text-orange-500 flex gap-2 items-center transition-all ${getActiveStyle(
router.pathname === "/starsearch"
router.pathname === "/star-search"
)}`}
href={"/starsearch"}
href={"/star-search"}
>
<img src="/assets/star-search-logo.svg" alt="Star Search logo" className="w-5 h-5" />
<p className="mt-0.5">StarSearch</p>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would we need to change the title and chat name and add the hyphen?

Expand Down
0 pages/starsearch.tsx → pages/star-search.tsx
View file
Open in desktop
File renamed without changes.
Loading