Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fixed star search URL for SEO #3218

Merged
merged 1 commit into from
Apr 17, 2024

Conversation

nickytonline
Copy link
Member

@nickytonline nickytonline commented Apr 17, 2024

Description

Updates the StarSearch url from /starsearch to /star-search

Related Tickets & Documents

Fixes #3219

Mobile & Desktop Screenshots/Recordings

Steps to QA

  1. Ensure you're in the feature flag cohort for Star Search.
  2. Navigate to /star-search and the StarSearch page loads.
  3. Navigate to /starsearch and the p. age 404s.

Tier (staff will fill in)

  • Tier 1
  • Tier 2
  • Tier 3
  • Tier 4

[optional] Are there any post-deployment tasks we need to perform?

[optional] What gif best describes this PR or how it makes you feel?

Copy link

netlify bot commented Apr 17, 2024

Deploy Preview for design-insights ready!

Name Link
🔨 Latest commit 5cfcc99
🔍 Latest deploy log https://app.netlify.com/sites/design-insights/deploys/662020ddf1b8d0000832a4a7
😎 Deploy Preview https://deploy-preview-3218--design-insights.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Apr 17, 2024

Deploy Preview for oss-insights ready!

Name Link
🔨 Latest commit 5cfcc99
🔍 Latest deploy log https://app.netlify.com/sites/oss-insights/deploys/662020dd193ef3000839676e
😎 Deploy Preview https://deploy-preview-3218--oss-insights.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@bdougie bdougie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀🚀🚀

)}`}
href={"/starsearch"}
href={"/star-search"}
>
<img src="/assets/star-search-logo.svg" alt="Star Search logo" className="w-5 h-5" />
<p className="mt-0.5">StarSearch</p>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would we need to change the title and chat name and add the hyphen?

@brandonroberts brandonroberts merged commit 69f8d67 into beta Apr 17, 2024
19 checks passed
@brandonroberts brandonroberts deleted the nickytonline/url-update-star-search branch April 17, 2024 19:31
open-sauced bot pushed a commit that referenced this pull request Apr 17, 2024
## [2.19.0-beta.15](v2.19.0-beta.14...v2.19.0-beta.15) (2024-04-17)

### 🐛 Bug Fixes

* fixed star search URL for SEO ([#3218](#3218)) ([69f8d67](69f8d67))
open-sauced bot pushed a commit that referenced this pull request Apr 17, 2024
## [2.19.0](v2.18.0...v2.19.0) (2024-04-17)

### 🐛 Bug Fixes

* fixed star search URL for SEO ([#3218](#3218)) ([69f8d67](69f8d67))
* now links in collapsed sidebar no longer receive focus ([#3187](#3187)) ([5b05ace](5b05ace))
* now repo page OG images are corrext for production ([#3179](#3179)) ([772c7b5](772c7b5))
* now there is feedback when saving or updating workspace settings ([#3184](#3184)) ([43784b2](43784b2))
* quick fix StarSearch response ([#3194](#3194)) ([0c2847e](0c2847e))
* remove console.info call from mutateHandler in AppSidebar component ([#3185](#3185)) ([96b63d7](96b63d7))
* removed activity column from contributor grid ([#3206](#3206)) ([4b11168](4b11168))
* removed deprecated list pages ([#3197](#3197)) ([fa14557](fa14557))
* update logic for most used languages to match contributor profile ([#3205](#3205)) ([e8f8a75](e8f8a75))
* updated styles of create insights links in sidebar ([#3173](#3173)) ([6c0c5ce](6c0c5ce))

### 🍕 Features

* add link from Repo pages to GitHub ([#3177](#3177)) ([f4e1de4](f4e1de4))
* add support for blogpost from generic platforms  ([#2555](#2555)) ([8ca6f25](8ca6f25))
* basic implementation of StarSearch ([#3162](#3162)) ([0086134](0086134))
* change repo links from github to repo pages ([#3178](#3178)) ([506dde2](506dde2))
* Create robots.txt ([#3183](#3183)) ([751c561](751c561))
* created the workspace activity page with a pull requests table ([#3147](#3147)) ([9f65b9c](9f65b9c))
* rename cumulative to history in Repo pages ([#3195](#3195)) ([8a33e24](8a33e24))
* render markdown for `/starsearch` responses ([#3204](#3204)) ([49ce317](49ce317))
* styling `/starsearch` ([#3211](#3211)) ([5e4c037](5e4c037))
* switch [#100](#100 banner with Workspaces banner on feed page ([#3216](#3216)) ([417e98b](417e98b))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Add a hyphen in the StarSearch URL
4 participants