-
-
Notifications
You must be signed in to change notification settings - Fork 147
Feature: Replace placeholder avatars with contributor avatars #21
Comments
Is there no link to fetch the Avatars? |
Yes and not. You can fetch the contributors of repository and you can fetch avatars using github usernames separately. Link to how it is done in the main repo: https://github.com/open-sauced/open-sauced/blob/bf2501d0320c282695b563e02b7394f871557d0d/src/components/Repository.js#L119
I will address the following to unblock this - #23 |
I'd love to take this one on once it's unblocked! So just to make sure I'm clear on what the task at hand is, we want to replace the placeholder avatars with avatars coming from the github api? Also since we are rendering a list of repos from a static list of items in a json file, would we be replacing that with the data from the github API or something else? |
The placeholder images should be actual avatars of the top 2 contributors of the project.
replacing that with the data from the github API or something else? #25 will unblock this. |
Okay I see, gotcha! Will wait for that to be merged |
This is now unblocked, the data was added to the static JSON file. The avatars can now be dynamically rendered. I will be adding the fetch logic to the action that populates the DB. i.e. https://github.com/open-sauced/actions/blob/main/populate-the-supabase/action.js#L27-L55 |
.take |
Thanks for taking this on! If you have not already, join the conversation in our Discord |
* feat: replace avatar fixtures with contributor avatars fixes #21 * test: add tests for getAvatar * style: adddress linting issues
🎉 This issue has been resolved in version 1.2.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Type of feature
Feature
Current behavior
Within each repo card, the list avatars are placeholders. This was needed to figure out the design, but they will need to be replaced with the avatars of the contributors.
Desired solution
In the opensauced.pizza app, we grab the avatars using graphql. We can do something similar here.
Example in the opensauced dashboard
Additional context
This can be completed without a github OAuth
Code of Conduct
Update:
This issue is blocked on the need for a proper data fetching pattern from GitHub.
The text was updated successfully, but these errors were encountered: