-
-
Notifications
You must be signed in to change notification settings - Fork 147
Conversation
✔️ Deploy Preview for hot-sauced-ui ready! 🔨 Explore the source changes: 6910eb6 🔍 Inspect the deploy log: https://app.netlify.com/sites/hot-sauced-ui/deploys/61c24a697513a8000846e1b9 😎 Browse the preview: https://deploy-preview-25--hot-sauced-ui.netlify.app/ |
be7efb4
to
e618651
Compare
e618651
to
de9605e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any reason why you excluded the prettier plugin?. Just asking out of curiosity
added it to format the portion of my code that did not meet the standard, but used |
note to self: Already noticing a rate-limiting issue here. I will need to move this data fetching to the static API for sure. Going to test that out before merging this. |
a64d4aa
to
6910eb6
Compare
## [1.1.0](v1.0.1...v1.1.0) (2021-12-21) ### 🍕 Features * add contributor data ([#25](#25)) ([156907c](156907c))
🎉 This PR is included in version 1.1.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
What type of PR is this? (check all applicable)
Description
This PR adds GitHub data to the UI elements. Leveraging the same open-sauced query from the main repository.
This approach does introduce some rendering bugs, primarily due to the slowness of the data fetching. Local or API caching will need to be introduced. The main goal for this was, to unblock #21 and allow contributor fetching for the placeholder avatars.
I will update the API to include description data.
UPDATE:
Adding fetching to the site was not ideal. Moving that logic to the API, but this PR will revert back to using the static JSON file for now.
Related Tickets & Documents
#21
closes #23
Mobile & Desktop Screenshots/Recordings
Added tests?
Added to documentation?
[optional] Are there any post-deployment tasks we need to perform?
[optional] What gif best describes this PR or how it makes you feel?