Skip to content
This repository has been archived by the owner on Sep 26, 2024. It is now read-only.

feat: add contributor data #25

Merged
merged 10 commits into from
Dec 21, 2021
Merged

feat: add contributor data #25

merged 10 commits into from
Dec 21, 2021

Conversation

bdougie
Copy link
Member

@bdougie bdougie commented Dec 20, 2021

What type of PR is this? (check all applicable)

  • ♻️ Refactor
  • ✨ Feature
  • 🐛 Bug Fix
  • 👷 Optimization
  • 📝 Documentation Update
  • 🔖 Release
  • 🚩 Other

Description

This PR adds GitHub data to the UI elements. Leveraging the same open-sauced query from the main repository.

This approach does introduce some rendering bugs, primarily due to the slowness of the data fetching. Local or API caching will need to be introduced. The main goal for this was, to unblock #21 and allow contributor fetching for the placeholder avatars.

I will update the API to include description data.

UPDATE:

Adding fetching to the site was not ideal. Moving that logic to the API, but this PR will revert back to using the static JSON file for now.

Related Tickets & Documents

#21
closes #23

Mobile & Desktop Screenshots/Recordings

Screen Shot 2021-12-20 at 5 12 51 AM

Added tests?

  • 👍 yes
  • 🙅 no, because they aren't needed
  • 🙋 no, because I need help

Added to documentation?

  • 📜 readme
  • 📜 contributing.md
  • 📓 docs
  • 📕 storybook
  • 🙅 no documentation needed

[optional] Are there any post-deployment tasks we need to perform?

[optional] What gif best describes this PR or how it makes you feel?

@netlify
Copy link

netlify bot commented Dec 20, 2021

✔️ Deploy Preview for hot-sauced-ui ready!

🔨 Explore the source changes: 6910eb6

🔍 Inspect the deploy log: https://app.netlify.com/sites/hot-sauced-ui/deploys/61c24a697513a8000846e1b9

😎 Browse the preview: https://deploy-preview-25--hot-sauced-ui.netlify.app/

@bdougie bdougie changed the title feature: add contributor data feat: add contributor data Dec 20, 2021
Copy link
Contributor

@kelvinsekx kelvinsekx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any reason why you excluded the prettier plugin?. Just asking out of curiosity

@bdougie
Copy link
Member Author

bdougie commented Dec 20, 2021

Any reason why you excluded the prettier plugin?. Just asking out of curiosity

added it to format the portion of my code that did not meet the standard, but used npm run format instead, which is eslint. Since I am not using it, doesn't make sense to keep in this PR. I prefer to keep the changes relevant to the original problem and not introduce unrelated things that would make the PR harder to review.

@bdougie
Copy link
Member Author

bdougie commented Dec 20, 2021

note to self: Already noticing a rate-limiting issue here. I will need to move this data fetching to the static API for sure. Going to test that out before merging this.

@bdougie bdougie merged commit 156907c into main Dec 21, 2021
github-actions bot pushed a commit that referenced this pull request Dec 21, 2021
## [1.1.0](v1.0.1...v1.1.0) (2021-12-21)

### 🍕 Features

* add contributor data ([#25](#25)) ([156907c](156907c))
@github-actions
Copy link

🎉 This PR is included in version 1.1.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@0-vortex 0-vortex deleted the 21-add-contributor-data branch January 27, 2022 16:29
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Include the Open Sauced Persisted query data fetching and API from OneGraph
2 participants