feat: Implement Card Table Component #243

chadstewart · 2022-08-21T13:16:03Z

What type of PR is this? (check all applicable)

Description

This PR adds the feature of the Card Table component

Details:

Nothing too crazy in this PR.

Leveraged React Icons for the Icons and updating the color and such.
prStatus says whether PR is merged, closed, etc.
The 'title' prop will add alt text to React-Icon components
Added the type of PRs to this component which will need to be moved in refactor: correct typescript types usage across the application #212

Related Tickets & Documents

Fixes #223

Mobile & Desktop Screenshots/Recordings

Added tests?

👍 yes
🙅 no, because they aren't needed
🙋 no, because I need help

Added to documentation?

[optional] Are there any post-deployment tasks we need to perform?

[optional] What gif best describes this PR or how it makes you feel?

netlify · 2022-08-21T13:16:07Z

✅ Deploy Preview for oss-insights ready!

Name	Link
🔨 Latest commit	`137d22c`
🔍 Latest deploy log	https://app.netlify.com/sites/oss-insights/deploys/6304e276b0e37d0009597ab0
😎 Deploy Preview	https://deploy-preview-243--oss-insights.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

netlify · 2022-08-21T13:16:13Z

✅ Deploy Preview for design-insights ready!

Name	Link
🔨 Latest commit	`137d22c`
🔍 Latest deploy log	https://app.netlify.com/sites/design-insights/deploys/6304e276f2e6960008b4046b
😎 Deploy Preview	https://deploy-preview-243--design-insights.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

components/molecules/CardTable/card-table.tsx

bdougie · 2022-08-21T23:09:32Z

Overall this is looking good. The padding seems way off everywhere. Padding needs to be tighter.

Design

Implementation

bdougie

We need better naming for this. card-table is not flexible as-is and doesn't need to be.

rename card-table to contributor-table
PR item types need to explicit and not itemX
Padding does not seem to match the design spec.

… component based on code review feedback.

bdougie

Looks good.

components/molecules/ContributorTable/contributor-table.tsx

… React-icons to get alt text.

0-vortex

LGTM! 👍

pixelsbyeryc

LGTM

## [1.3.0-beta.8](v1.3.0-beta.7...v1.3.0-beta.8) (2022-08-23) ### 🍕 Features * Implement Card Table Component ([#243](#243)) ([0cbc6ea](0cbc6ea))

github-actions · 2022-08-23T21:28:58Z

🎉 This PR is included in version 1.3.0-beta.8 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

## [1.3.0](v1.2.3...v1.3.0) (2022-08-29) ### 🧑‍💻 Code Refactoring * Improve the `<ComponentCard>` CSS ([#266](#266)) ([9da4d62](9da4d62)) * Make the avatar component accept custom sizes ([#255](#255)) ([9076e91](9076e91)), closes [#235](#235) ### 🍕 Features * Add Images to Scatter Chart ([#257](#257)) ([20df419](20df419)) * Add item count meta data to Highlight Card ([#254](#254)) ([693479e](693479e)) * Added Reports History component to Reports Page ([#272](#272)) ([c6a56f6](c6a56f6)) * Implement Card Horizontal Bar component ([#237](#237)) ([7bbbe40](7bbbe40)) * Implement Card Table Component ([#243](#243)) ([0cbc6ea](0cbc6ea)) * Implement contribution page ([#263](#263)) ([f41d7f9](f41d7f9)) * Implement Contributor Card Component ([#245](#245)) ([3bd55ea](3bd55ea)) * Implement Reports History Component ([#209](#209)) ([bb531e4](bb531e4)) * Implement the hacktoberfest reports page ([#229](#229)) ([0cfa5e5](0cfa5e5)), closes [#168](#168) * Implement waitlist page ([#210](#210)) ([0826d07](0826d07)), closes [#152](#152) ### 🐛 Bug Fixes * adjusted opinion filter on mobile screens ([#264](#264)) ([2d9785c](2d9785c)) * correct login redirect issues in supabase implemetation ([#274](#274)) ([8fcd81e](8fcd81e)) * correct login redirect issues in supabase implemetation x2 ([#275](#275)) ([0239abd](0239abd)) * correct supabase-ui default style for hover ([#267](#267)) ([a23fe4b](a23fe4b)), closes [#226](#226) * increase truncate string number of words ([#268](#268)) ([ab47a96](ab47a96)), closes [#247](#247) * max width removed from card ([#250](#250)) ([523969a](523969a)), closes [#249](#249) * removes unused function ([b37de35](b37de35)) * Repo count ([#244](#244)) ([d59eef8](d59eef8)) * Update GitSense API route for repos ([#270](#270)) ([8f7e1c5](8f7e1c5))

github-actions · 2022-08-29T19:53:20Z

🎉 This PR is included in version 1.3.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

## [1.3.0-beta.8](open-sauced/app@v1.3.0-beta.7...v1.3.0-beta.8) (2022-08-23) ### 🍕 Features * Implement Card Table Component ([#243](open-sauced/app#243)) ([0cbc6ea](open-sauced/app@0cbc6ea))

## [1.3.0](open-sauced/app@v1.2.3...v1.3.0) (2022-08-29) ### 🧑‍💻 Code Refactoring * Improve the `<ComponentCard>` CSS ([#266](open-sauced/app#266)) ([9da4d62](open-sauced/app@9da4d62)) * Make the avatar component accept custom sizes ([#255](open-sauced/app#255)) ([9076e91](open-sauced/app@9076e91)), closes [#235](open-sauced/app#235) ### 🍕 Features * Add Images to Scatter Chart ([#257](open-sauced/app#257)) ([20df419](open-sauced/app@20df419)) * Add item count meta data to Highlight Card ([#254](open-sauced/app#254)) ([693479e](open-sauced/app@693479e)) * Added Reports History component to Reports Page ([#272](open-sauced/app#272)) ([c6a56f6](open-sauced/app@c6a56f6)) * Implement Card Horizontal Bar component ([#237](open-sauced/app#237)) ([7bbbe40](open-sauced/app@7bbbe40)) * Implement Card Table Component ([#243](open-sauced/app#243)) ([0cbc6ea](open-sauced/app@0cbc6ea)) * Implement contribution page ([#263](open-sauced/app#263)) ([f41d7f9](open-sauced/app@f41d7f9)) * Implement Contributor Card Component ([#245](open-sauced/app#245)) ([3bd55ea](open-sauced/app@3bd55ea)) * Implement Reports History Component ([#209](open-sauced/app#209)) ([bb531e4](open-sauced/app@bb531e4)) * Implement the hacktoberfest reports page ([#229](open-sauced/app#229)) ([0cfa5e5](open-sauced/app@0cfa5e5)), closes [#168](open-sauced/app#168) * Implement waitlist page ([#210](open-sauced/app#210)) ([0826d07](open-sauced/app@0826d07)), closes [#152](open-sauced/app#152) ### 🐛 Bug Fixes * adjusted opinion filter on mobile screens ([#264](open-sauced/app#264)) ([2d9785c](open-sauced/app@2d9785c)) * correct login redirect issues in supabase implemetation ([#274](open-sauced/app#274)) ([8fcd81e](open-sauced/app@8fcd81e)) * correct login redirect issues in supabase implemetation x2 ([#275](open-sauced/app#275)) ([0239abd](open-sauced/app@0239abd)) * correct supabase-ui default style for hover ([#267](open-sauced/app#267)) ([a23fe4b](open-sauced/app@a23fe4b)), closes [#226](open-sauced/app#226) * increase truncate string number of words ([#268](open-sauced/app#268)) ([ab47a96](open-sauced/app@ab47a96)), closes [#247](open-sauced/app#247) * max width removed from card ([#250](open-sauced/app#250)) ([523969a](open-sauced/app@523969a)), closes [#249](open-sauced/app#249) * removes unused function ([b37de35](open-sauced/app@b37de35)) * Repo count ([#244](open-sauced/app#244)) ([d59eef8](open-sauced/app@d59eef8)) * Update GitSense API route for repos ([#270](open-sauced/app#270)) ([8f7e1c5](open-sauced/app@8f7e1c5))

Initial commit for card table component.

9cdb965

chadstewart added 4 commits August 21, 2022 09:12

Working on general structure of table and header.

87924d8

Completed header for card table.

3b96589

Working on table body

b2caf3f

Finished card table component.

257cd05

chadstewart requested review from 0-vortex, bdougie and pixelsbyeryc August 21, 2022 21:27

chadstewart marked this pull request as ready for review August 21, 2022 21:27

chadstewart added the awaiting review label Aug 21, 2022

bdougie reviewed Aug 21, 2022

View reviewed changes

components/molecules/CardTable/card-table.tsx Outdated Show resolved Hide resolved

bdougie reviewed Aug 21, 2022

View reviewed changes

components/molecules/CardTable/card-table.tsx Outdated Show resolved Hide resolved

bdougie requested changes Aug 21, 2022

View reviewed changes

bdougie added requested changes and removed awaiting review labels Aug 21, 2022

chadstewart added 2 commits August 21, 2022 18:56

Renamed card table to contributor table and changed padding for table…

17b1dab

… component based on code review feedback.

Forgot to update padding on copmonent all components.

42439c2

bdougie approved these changes Aug 22, 2022

View reviewed changes

bdougie removed the requested changes label Aug 22, 2022

chadstewart mentioned this pull request Aug 22, 2022

[Design] Create 'No PRs' design for Contributor Table (formerly Card Table) component #253

Closed

chadstewart added the help wanted Extra attention is needed label Aug 22, 2022

pixelsbyeryc suggested changes Aug 22, 2022

View reviewed changes

components/molecules/ContributorTable/contributor-table.tsx Outdated Show resolved Hide resolved

components/molecules/ContributorTable/contributor-table.tsx Outdated Show resolved Hide resolved

components/molecules/ContributorTable/contributor-table.tsx Outdated Show resolved Hide resolved

pixelsbyeryc suggested changes Aug 22, 2022

View reviewed changes

components/molecules/ContributorTable/contributor-table.tsx Outdated Show resolved Hide resolved

chadstewart added 3 commits August 22, 2022 14:03

Updated interface in contributor table based on code review.

9d9e6d8

Forgot to update the story with the changes of the interface.

149c0f6

Updated alt text for icons. Please note that you need to use title in…

dd97cbe

… React-icons to get alt text.

chadstewart removed the help wanted Extra attention is needed label Aug 23, 2022

chadstewart added 2 commits August 23, 2022 09:00

Updating CSS based on code review.

058c5ad

Updated react icons to get them to match more closely with one another.

137d22c

chadstewart requested a review from pixelsbyeryc August 23, 2022 14:22

chadstewart added the awaiting review label Aug 23, 2022

0-vortex approved these changes Aug 23, 2022

View reviewed changes

chadstewart mentioned this pull request Aug 23, 2022

[Refactor] Investigate directly adding Octicons to project to better match design. #259

Closed

7 tasks

pixelsbyeryc approved these changes Aug 23, 2022

View reviewed changes

chadstewart removed the awaiting review label Aug 23, 2022

chadstewart merged commit 0cbc6ea into beta Aug 23, 2022

chadstewart deleted the 223-card-table branch August 23, 2022 21:25

github-actions bot added the released on @beta label Aug 23, 2022

github-actions bot added the released label Aug 29, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: Implement Card Table Component #243

feat: Implement Card Table Component #243

chadstewart commented Aug 21, 2022 •

edited

netlify bot commented Aug 21, 2022 •

edited

netlify bot commented Aug 21, 2022 •

edited

bdougie commented Aug 21, 2022

bdougie left a comment

bdougie left a comment

0-vortex left a comment

pixelsbyeryc left a comment

github-actions bot commented Aug 23, 2022

github-actions bot commented Aug 29, 2022

feat: Implement Card Table Component #243

feat: Implement Card Table Component #243

Conversation

chadstewart commented Aug 21, 2022 • edited

What type of PR is this? (check all applicable)

Description

Related Tickets & Documents

Mobile & Desktop Screenshots/Recordings

Added tests?

Added to documentation?

[optional] Are there any post-deployment tasks we need to perform?

[optional] What gif best describes this PR or how it makes you feel?

netlify bot commented Aug 21, 2022 • edited

✅ Deploy Preview for oss-insights ready!

netlify bot commented Aug 21, 2022 • edited

✅ Deploy Preview for design-insights ready!

bdougie commented Aug 21, 2022

Design

Implementation

bdougie left a comment

Choose a reason for hiding this comment

bdougie left a comment

Choose a reason for hiding this comment

0-vortex left a comment

Choose a reason for hiding this comment

pixelsbyeryc left a comment

Choose a reason for hiding this comment

github-actions bot commented Aug 23, 2022

github-actions bot commented Aug 29, 2022

chadstewart commented Aug 21, 2022 •

edited

netlify bot commented Aug 21, 2022 •

edited

netlify bot commented Aug 21, 2022 •

edited