Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: Too many languages in <ContributorCard>. Should be top 5. #402

Closed
Tracked by #400
eryc-cc opened this issue Sep 20, 2022 · 7 comments · Fixed by #441
Closed
Tracked by #400

bug: Too many languages in <ContributorCard>. Should be top 5. #402

eryc-cc opened this issue Sep 20, 2022 · 7 comments · Fixed by #441
Assignees
Labels

Comments

@eryc-cc
Copy link
Contributor

eryc-cc commented Sep 20, 2022

Summary

There are too many languages allowed to be shown in this card. It should be the top 5, and if there are more, they should be grouped under "other".

Screen Shot 2022-09-20 at 11 29 13 AM

@eryc-cc eryc-cc added 🍕 enhancement New feature or request 🐛 bug Something isn't working and removed 🍕 enhancement New feature or request labels Sep 20, 2022
@eryc-cc
Copy link
Contributor Author

eryc-cc commented Sep 20, 2022

@0-vortex @brandonroberts @chadstewart @sungoldtech

Who should we assign this to?

@0-vortex
Copy link
Contributor

@OgDev-01
Copy link
Contributor

@pixelsbyeryc,

and if there are more, they should be grouped under "other".

will an updated design be created to add this to the frontend?

@eryc-cc
Copy link
Contributor Author

eryc-cc commented Sep 28, 2022

@pixelsbyeryc,

and if there are more, they should be grouped under "other".

will an updated design be created to add this to the frontend?

No, it's just a matter of removing the extra ones.

They should also be sized relative to the amount of code, like GitHub does...

Here's an example of GitHub: the size of each color is different, related to how much code is in that language

Screen Shot 2022-09-28 at 4 16 54 PM

github-actions bot pushed a commit that referenced this issue Sep 28, 2022
## [1.7.0-beta.14](v1.7.0-beta.13...v1.7.0-beta.14) (2022-09-28)

### 🐛 Bug Fixes

* limit number of languages in contibutor's card ([#441](#441)) ([4aba355](4aba355)), closes [#402](#402)
@github-actions
Copy link

🎉 This issue has been resolved in version 1.7.0-beta.14 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

github-actions bot pushed a commit that referenced this issue Sep 28, 2022
## [1.8.0-beta.1](v1.7.0...v1.8.0-beta.1) (2022-09-28)

### 🍕 Features

* add data from API to contributors page for hacktoberfest ([#431](#431)) ([56e12ea](56e12ea)), closes [#404](#404)
* Add truncate string for long pr names ([#440](#440)) ([35b8541](35b8541)), closes [#438](#438)
* adds initial support for restricting reports by user roles ([#451](#451)) ([15a7643](15a7643)), closes [#395](#395)

### 🐛 Bug Fixes

* adds links to footer ([#432](#432)) ([7adfbe7](7adfbe7))
* inverse the scatter chart ([#433](#433)) ([18dd094](18dd094)), closes [#399](#399)
* limit number of languages in contibutor's card ([#441](#441)) ([4aba355](4aba355)), closes [#402](#402)
* remove link from highlight card component ([#435](#435)) ([25b6997](25b6997))
* remove remaining mock data for contributors ([#443](#443)) ([974c739](974c739)), closes [#404](#404) [#444](#444)
@github-actions
Copy link

🎉 This issue has been resolved in version 1.8.0-beta.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

github-actions bot pushed a commit that referenced this issue Sep 28, 2022
## [1.8.0](v1.7.0...v1.8.0) (2022-09-28)

### 🍕 Features

* add data from API to contributors page for hacktoberfest ([#431](#431)) ([56e12ea](56e12ea)), closes [#404](#404)
* Add truncate string for long pr names ([#440](#440)) ([35b8541](35b8541)), closes [#438](#438)
* adds initial support for restricting reports by user roles ([#451](#451)) ([15a7643](15a7643)), closes [#395](#395)

### 🐛 Bug Fixes

* adds links to footer ([#432](#432)) ([7adfbe7](7adfbe7))
* inverse the scatter chart ([#433](#433)) ([18dd094](18dd094)), closes [#399](#399)
* limit number of languages in contibutor's card ([#441](#441)) ([4aba355](4aba355)), closes [#402](#402)
* remove link from highlight card component ([#435](#435)) ([25b6997](25b6997))
* remove remaining mock data for contributors ([#443](#443)) ([974c739](974c739)), closes [#404](#404) [#444](#444)
@github-actions
Copy link

🎉 This issue has been resolved in version 1.8.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

ElpisHelle added a commit to ElpisHelle/next.js-tailwindcss that referenced this issue Aug 17, 2023
## [1.7.0-beta.14](open-sauced/app@v1.7.0-beta.13...v1.7.0-beta.14) (2022-09-28)

### 🐛 Bug Fixes

* limit number of languages in contibutor's card ([#441](open-sauced/app#441)) ([4aba355](open-sauced/app@4aba355)), closes [#402](open-sauced/app#402)
ElpisHelle added a commit to ElpisHelle/next.js-tailwindcss that referenced this issue Aug 17, 2023
## [1.8.0-beta.1](open-sauced/app@v1.7.0...v1.8.0-beta.1) (2022-09-28)

### 🍕 Features

* add data from API to contributors page for hacktoberfest ([#431](open-sauced/app#431)) ([56e12ea](open-sauced/app@56e12ea)), closes [#404](open-sauced/app#404)
* Add truncate string for long pr names ([#440](open-sauced/app#440)) ([35b8541](open-sauced/app@35b8541)), closes [#438](open-sauced/app#438)
* adds initial support for restricting reports by user roles ([#451](open-sauced/app#451)) ([15a7643](open-sauced/app@15a7643)), closes [#395](open-sauced/app#395)

### 🐛 Bug Fixes

* adds links to footer ([#432](open-sauced/app#432)) ([7adfbe7](open-sauced/app@7adfbe7))
* inverse the scatter chart ([#433](open-sauced/app#433)) ([18dd094](open-sauced/app@18dd094)), closes [#399](open-sauced/app#399)
* limit number of languages in contibutor's card ([#441](open-sauced/app#441)) ([4aba355](open-sauced/app@4aba355)), closes [#402](open-sauced/app#402)
* remove link from highlight card component ([#435](open-sauced/app#435)) ([25b6997](open-sauced/app@25b6997))
* remove remaining mock data for contributors ([#443](open-sauced/app#443)) ([974c739](open-sauced/app@974c739)), closes [#404](open-sauced/app#404) [#444](open-sauced/app#444)
ElpisHelle added a commit to ElpisHelle/next.js-tailwindcss that referenced this issue Aug 17, 2023
## [1.8.0](open-sauced/app@v1.7.0...v1.8.0) (2022-09-28)

### 🍕 Features

* add data from API to contributors page for hacktoberfest ([#431](open-sauced/app#431)) ([56e12ea](open-sauced/app@56e12ea)), closes [#404](open-sauced/app#404)
* Add truncate string for long pr names ([#440](open-sauced/app#440)) ([35b8541](open-sauced/app@35b8541)), closes [#438](open-sauced/app#438)
* adds initial support for restricting reports by user roles ([#451](open-sauced/app#451)) ([15a7643](open-sauced/app@15a7643)), closes [#395](open-sauced/app#395)

### 🐛 Bug Fixes

* adds links to footer ([#432](open-sauced/app#432)) ([7adfbe7](open-sauced/app@7adfbe7))
* inverse the scatter chart ([#433](open-sauced/app#433)) ([18dd094](open-sauced/app@18dd094)), closes [#399](open-sauced/app#399)
* limit number of languages in contibutor's card ([#441](open-sauced/app#441)) ([4aba355](open-sauced/app@4aba355)), closes [#402](open-sauced/app#402)
* remove link from highlight card component ([#435](open-sauced/app#435)) ([25b6997](open-sauced/app@25b6997))
* remove remaining mock data for contributors ([#443](open-sauced/app#443)) ([974c739](open-sauced/app@974c739)), closes [#404](open-sauced/app#404) [#444](open-sauced/app#444)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

3 participants