Skip to content

Conversation

baylesj
Copy link
Contributor

@baylesj baylesj commented Nov 14, 2019

CPPTL support is no longer relevant to JsonCpp, and can be removed from
the library. This patch removes all mentions of CPPTL, by removing all
definitions and code sections conditionally compiled only when JsonCpp
is used with CPPTL. Include guards are also renamed to not refer to
CPPTL where appropriate.

See issue #1100

CPPTL support is no longer relevant to JsonCpp, and can be removed from
the library. This patch removes all mentions of CPPTL, by removing all
definitions and code sections conditionally compiled only when JsonCpp
is used with CPPTL. Include guards are also renamed to not refer to
CPPTL where appropriate.
@baylesj baylesj requested a review from cdunn2001 November 14, 2019 17:40
@coveralls
Copy link

coveralls commented Nov 14, 2019

Coverage Status

Coverage remained the same at 90.672% when pulling a481201 on drop_cpptl_support into 781eec4 on master.

Copy link
Contributor

@cdunn2001 cdunn2001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is independent of pretty much any other change we can make, so I'll merge it immediately.

@@ -6,7 +6,7 @@
#ifndef JSON_JSON_H_INCLUDED
#define JSON_JSON_H_INCLUDED

#include "autolink.h"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't even know what autolink.h was!

@cdunn2001 cdunn2001 merged commit cfc3e92 into master Nov 15, 2019
@cdunn2001 cdunn2001 deleted the drop_cpptl_support branch November 15, 2019 06:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants