Skip to content

Update config.h #292

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Update config.h #292

wants to merge 1 commit into from

Conversation

eyjian
Copy link

@eyjian eyjian commented Jun 11, 2015

include/json/config.h:100: error: ISO C++ does not support 'long long'
include/json/config.h:101: error: ISO C++ does not support 'long long'

@eyjian
Update config.h
605fbe9 
include/json/config.h:100: error: ISO C++ does not support 'long long'
include/json/config.h:101: error: ISO C++ does not support 'long long'
@cdunn2001
Copy link
Contributor

This is for VisualStudio? Which versions should this work for? We might have to revert if we get complaints.

We appreciate the submission though. If the AppVeyor tests pass, I'll merge this.

@cdunn2001 cdunn2001 self-assigned this Jun 11, 2015
@cdunn2001 cdunn2001 added the bug label Jun 11, 2015
@eyjian
Copy link
Author

eyjian commented Jun 11, 2015

$ g++ --version
g++ (GCC) 4.1.0 (SUSE Linux)

$ make --version
GNU Make 3.80

Reference：http://blog.chinaunix.net/uid-20682147-id-5078298.html

@cdunn2001
Copy link
Contributor

Oh, the comment mislead me: #else // if defined(_MSC_VER) // Other. It should say the opposite.

So this change is for all compilers except MSC? That's a non-starter. __exception__ is not a universal symbol.

Maybe we just need -Wno-long-long for old gcc in cmake?

Anyway, if you're using an old compiler, you're lucky it works. Use the 0.y.z branch (or a recent 0.*.* release). That one will maintain backward compatibility. Please let us know whether that branch works for you.

ya1gaurav added a commit to ya1gaurav/jsoncpp that referenced this pull request Jul 4, 2015
@ya1gaurav
GCC warning removal for long long
115a470 
I got below warning message on x86 linux machine :
"jsoncpp-0.10.2-p1/include/json/config.h:100: warning: ISO C++ 1998 does not support ‘long long’"
gcc version 4.4.7 20120313 (Red Hat 4.4.7-4) (GCC)
In reference to 
open-source-parsers#292
long long is supported in c++-11, for old compilers i.e 0.x.y branch this patch should be merged.
@ya1gaurav ya1gaurav mentioned this pull request Jul 4, 2015
Closed
cdunn2001 pushed a commit to cdunn2001/jsoncpp that referenced this pull request Jul 11, 2015
@ya1gaurav @cdunn2001
GCC warning removal for long long
f1cafb6 
(was open-source-parsers#300)

I got below warning message on x86 linux machine :
```
"jsoncpp-0.10.2-p1/include/json/config.h:100: warning: ISO C++ 1998 does not support ‘long long’"
gcc version 4.4.7 20120313 (Red Hat 4.4.7-4) (GCC)
```
In reference to

* open-source-parsers#292

**long long** is supported in c++-11; for old compilers i.e `0.y.z` branch this patch should be merged.
@cdunn2001
Copy link
Contributor

The 0.y.z branch now has -Wno-long-long. For master, you need a more recent compiler.

@cdunn2001 cdunn2001 closed this Jul 11, 2015
@cdunn2001 cdunn2001 added wontfix and removed bug labels Jul 11, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@cdunn2001 cdunn2001

Labels
wontfix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eyjian @cdunn2001