fix gcc warning when CXXFLAGS contains '-Wextra' #84
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
json_value.cpp:179:26: warning: enumeral and non-enumeral type in conditional expression [enabled by default]
cdunn2001
pushed a commit
that referenced
this pull request
Nov 20, 2014
json_value.cpp:179:26: warning: enumeral and non-enumeral type in conditional expression [enabled by default] #84
|
Rebased and pulled. Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When CXXFLAGS contains '-Wextra', as I set
SET(CMAKE_CXX_FLAGS_RELEASE ‘-Wall -Wextra’)
in root CMakeLists.txt.
I got the following error:
json_value.cpp:179:26: warning: enumeral and non-enumeral type in conditional expression [enabled by default]
I have describe it in the closed pull as follows:
#80
Thanks the help of Christopher Dunn
"
Yours will be slightly less efficient. I know this CZString stuff is kind of hacky, but why not use static_cast(other.index_ == noDuplication ? noDuplication : duplicate) after the question mark?
"
I test the modification and it works fine.