Add explicit move assignment operator #873
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hjmjohnson
approved these changes
Jan 20, 2019
There was a problem hiding this comment.
NIce. Thanks for making the function signature changes to match common conventions as mandated by the "rule-of-five"
https://cpppatterns.com/patterns/rule-of-five.html
|
Also, afaik when there are custom ctor/dtors compiler cannot add implicit move assignment operator which potentially may prevent some optimizations. |
|
correct. |
| Value& Value::operator=(Value other) { | ||
| Value& Value::operator=(const Value& other) { | ||
| Value tmp(other); | ||
| swap(tmp); |
There was a problem hiding this comment.
Swapping into a temporary is wasted work.
I think we should rather write "real" operators rather than relying on swap.
I'll work on that now and send a different PR proposal.
|
@pps83 Could you please rebase to resolve conflicts so that we may merge this branch? |
|
@pps83 This work was supperceeded by work of @BillyDonahue in 0c1cc6e. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this fixes linking error mentioned in #871 when building chrome/webrtc