Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/speed up finding optimal retention via brent's method #122

Merged

Conversation

@L-M-Sherlock L-M-Sherlock added the enhancement New feature or request label Nov 22, 2023
@L-M-Sherlock L-M-Sherlock linked an issue Nov 22, 2023 that may be closed by this pull request
@dae
Copy link
Collaborator

dae commented Nov 22, 2023

My review is focused on the Rust code, and not the math itself. Looks fine to me, but presumably we'll need to update the progress tracking code to capture the time spent in bracket(). Out of curiosity, how does a before/after benchmark perform?

@L-M-Sherlock
Copy link
Member Author

Out of curiosity, how does a before/after benchmark perform?

In debug mode, the test costs 38s for the old method. The new method costs 17s.

@dae
Copy link
Collaborator

dae commented Nov 22, 2023

Nice!

@L-M-Sherlock L-M-Sherlock merged commit 45fe88e into main Nov 22, 2023
3 checks passed
@L-M-Sherlock L-M-Sherlock deleted the Feat/speed-up-finding-optimal-retention-via-brents-method branch November 22, 2023 07:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TODO: speed up finding optimal retention via Brent's method
3 participants