-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: log to span exporter #3003
Conversation
Codecov Report
@@ Coverage Diff @@
## main #3003 +/- ##
==========================================
- Coverage 91.61% 91.38% -0.23%
==========================================
Files 486 478 -8
Lines 23519 23299 -220
==========================================
- Hits 21546 21291 -255
- Misses 1463 1510 +47
+ Partials 510 498 -12
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
W3CTraceContextFields W3CTraceContextFields `mapstructure:"w3c"` | ||
|
||
// SpanName defines the name of the span. | ||
SpanName string `mapstructure:"span_name"` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would it make sense to treat SpanName like the others and derive it from a specified attribute (maybe with an optional default)?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's exactly what it is; however, the comment is incorrect. haha
I also thought about having a default, but I'm not sure a default would ever be used...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
haha sorry that was obvious from context I just didn't catch it. Agreed probably no need for default.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No need to apologize. It helped catch the terrible comment :)
This PR was marked stale due to lack of activity. It will be closed in 7 days. |
This PR was marked stale due to lack of activity. It will be closed in 7 days. |
This PR was marked stale due to lack of activity. It will be closed in 7 days. |
Closed as inactive. Feel free to reopen if this PR is still being worked on. |
Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
It seems this PR got abandoned. We have an use case where access logs from a PaaS (Cloudfoundry) have the tracing headers like |
Description:
This exporter receives logs, converts them to trace spans, then exports the spans via OTLP over gRPC.
NOTE: This has been migrated from a PoC in a private distribution, and will be split up into multiple PRs once a more robust implementation is finalized.
Link to tracking Issue:
#3071
Testing:
Unit Tests
Documentation:
Code + README.