Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[receiver/datadog] new component: datadogreceiver #5836

Merged
merged 204 commits into from
Jan 31, 2023
Merged

[receiver/datadog] new component: datadogreceiver #5836

merged 204 commits into from
Jan 31, 2023

Conversation

boostchicken
Copy link
Member

@boostchicken boostchicken commented Oct 19, 2021 •
edited by jpkrohling
Loading

Description: Added ability to receive DD APM Traces

Testing: Tested in real world by adding plugin and sending DDAPM traces through

Documentation: https://github.com/boostchicken/opentelemetry-collector-contrib/blob/datadog-receiver/receiver/datadogreceiver/README.md

Closes #1852

@boostchicken
First cut
d03caa3
@boostchicken
Merge branch 'main' into datadog-receiver
a8336eb
@boostchicken
Updating implementation to 0.26
ea3785c
@boostchicken
Small convention updates
9578d10
@boostchicken
Added tests
aebe6d4
@boostchicken
Added tests
9e8e5f6
@boostchicken
README.md
9787ee4
@boostchicken
obs cleanup
52f19a5
@boostchicken
Moved to Datadog v05 code
45c9ddc
@boostchicken
Modified translator with new api code
479c331
@boostchicken
Code cleanup
57b1d7b
@boostchicken
Code cleanup
d4da3d2
@boostchicken
Code cleanup
a7e76f0
@boostchicken
Code cleanup
ffab5c0
@boostchicken
Refactor decode request
3ffc8c7
@boostchicken
Refactor decode request
975c80a
@boostchicken
Refactor decode request
4dbf2fc
@boostchicken
Refactor server lifecycle
4dfefbc
@boostchicken
Refactor server spankind
ebbdb86
@boostchicken
Moved translation engine and fixed translator
9f41cb8
@boostchicken
Moved translation engine and fixed translator
d248319
@boostchicken
Added resource
e3d9d21
@boostchicken
More todos
db1dc04
@boostchicken
More todos
b15002d
@boostchicken
More todos
d7b097e
@boostchicken
More todos
6a16963
@boostchicken
More todos
d41b80e
@boostchicken
Format cleanup
331d70c
@boostchicken
Basic Translator Benchmark test
8023ee1
@boostchicken
Correct trace id creation
b025439
boostchicken and others added 4 commits January 30, 2023 14:54
@boostchicken @codeboten
Update receiver/datadogreceiver/config_test.go
387a91e 
Co-authored-by: Alex Boten <alex@boten.ca>
@boostchicken @codeboten
Update receiver/datadogreceiver/factory_test.go
bef73f1 
Co-authored-by: Alex Boten <alex@boten.ca>
@boostchicken @codeboten
Update receiver/datadogreceiver/factory.go
18677ee 
Co-authored-by: Alex Boten <alex@boten.ca>
@boostchicken @codeboten
Update receiver/datadogreceiver/receiver.go
2620eac 
Co-authored-by: Alex Boten <alex@boten.ca>
@boostchicken
Copy link
Member Author

boostchicken commented Jan 30, 2023 •
edited
Loading

Hi @boostchicken ,

I've raised #18081 to help address the comments raised and help get this through. I've made sure your commit history is preserved to ensure that you're given the credit.

if this isn't acceptable, please let me know and I will close the PR and leave the comments to be addressed here.

You can toast your PR, I got everything addressed @MovieStoreGuy

@boostchicken
Copy link
Member Author

Ready for merge @jpkrohling

@MovieStoreGuy MovieStoreGuy added the ready to merge Code review completed; ready to merge by maintainers label Jan 31, 2023
This was referenced Jan 31, 2023
Closed
Closed
Closed
jpkrohling
jpkrohling reviewed Jan 31, 2023
View reviewed changes
Copy link
Member

@jpkrohling jpkrohling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are quite a few issues marked as Resolved but didn't seem to have been actually resolved. I believe most can be addressed in follow-up PRs, but I'm not sure which ones were really resolved already. I created tracker issues for two that I knew that need to be done soon, but before approving and merging, I would like you to go over the items I reopened and see if they are still relevant. If they are, please create an issue to track the tech debt.

receiver/datadogreceiver/factory.go Outdated Show resolved Hide resolved
receiver/datadogreceiver/receiver.go Outdated Show resolved Hide resolved
receiver/datadogreceiver/receiver.go Show resolved Hide resolved
receiver/datadogreceiver/receiver.go Show resolved Hide resolved
receiver/datadogreceiver/receiver_test.go Show resolved Hide resolved
receiver/datadogreceiver/translator.go Show resolved Hide resolved
jpkrohling
jpkrohling approved these changes Jan 31, 2023
View reviewed changes
Copy link
Member

@jpkrohling jpkrohling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM now, thank you!

@jpkrohling jpkrohling merged commit 3771eee into open-telemetry:main Jan 31, 2023
TylerHelmuth pushed a commit to TylerHelmuth/opentelemetry-collector-contrib that referenced this pull request Jan 31, 2023
@boostchicken @mx-psi
@gbbr @jpkrohling @MovieStoreGuy @codeboten
[receiver/datadog] Add Datadog receiver (open-telemetry#5836)
259b55a 
Signed-off-by: John <john.dorman@sony.com>
Signed-off-by: John <dorman@overlooked.us>
Signed-off-by: John Dorman <john@boostchicken.dev>
Co-authored-by: Pablo Baeyens <pbaeyens31+github@gmail.com>
Co-authored-by: Gabriel Aszalos <gabriel.aszalos@gmail.com>
Co-authored-by: Juraci Paixão Kröhling <juraci.github@kroehling.de>
Co-authored-by: Sean Marciniak <30928402+MovieStoreGuy@users.noreply.github.com>
Co-authored-by: Alex Boten <alex@boten.ca>
@boostchicken boostchicken deleted the datadog-receiver branch January 31, 2023 16:38
@boostchicken boostchicken changed the title [receiver/datadog] Add Datadog receiver [receiver/datadog] new component: datadogreceivver Feb 7, 2023
povilasv referenced this pull request in coralogix/opentelemetry-collector-contrib Feb 17, 2023
@boostchicken @mx-psi
@gbbr @jpkrohling @MovieStoreGuy @codeboten @povilasv
[receiver/datadog] Add Datadog receiver (#5836)
fd46f24 
Signed-off-by: John <john.dorman@sony.com>
Signed-off-by: John <dorman@overlooked.us>
Signed-off-by: John Dorman <john@boostchicken.dev>
Co-authored-by: Pablo Baeyens <pbaeyens31+github@gmail.com>
Co-authored-by: Gabriel Aszalos <gabriel.aszalos@gmail.com>
Co-authored-by: Juraci Paixão Kröhling <juraci.github@kroehling.de>
Co-authored-by: Sean Marciniak <30928402+MovieStoreGuy@users.noreply.github.com>
Co-authored-by: Alex Boten <alex@boten.ca>
@mvadu mvadu mentioned this pull request Mar 17, 2023
Closed
@boostchicken boostchicken changed the title [receiver/datadog] new component: datadogreceivver [receiver/datadog] new component: datadogreceiver Jun 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aybabtme aybabtme aybabtme left review comments

@mwear mwear mwear left review comments

@mx-psi mx-psi mx-psi left review comments

@gbbr gbbr gbbr left review comments

@TylerHelmuth TylerHelmuth TylerHelmuth left review comments

@moonheart moonheart moonheart left review comments

@MovieStoreGuy MovieStoreGuy MovieStoreGuy approved these changes

@jpkrohling jpkrohling jpkrohling approved these changes

@anuraaga anuraaga anuraaga approved these changes

@codeboten codeboten codeboten approved these changes

@dmitryax dmitryax Awaiting requested review from dmitryax

Assignees

@MovieStoreGuy MovieStoreGuy

Labels
ready to merge Code review completed; ready to merge by maintainers
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

DataDog APM Trace Agent Receiver Support