-
Notifications
You must be signed in to change notification settings - Fork 750
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Jaeger Propagator to Opentelemetry.Extensions.Propagators #3309
Conversation
* added jaeger progagator with tests * updated changelog * moved comment to unreleased
|
More of a question for the maintainers - do we want different propagators to be bundled as a single package or they should be decoupled? |
The Non W3C ones, zipkin/jaeger can be a single package. I think @alanwest suggested it that way earlier, and I agree. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Codecov Report
@@ Coverage Diff @@
## main #3309 +/- ##
==========================================
- Coverage 85.90% 85.78% -0.12%
==========================================
Files 267 268 +1
Lines 9383 9448 +65
==========================================
+ Hits 8060 8105 +45
- Misses 1323 1343 +20
|
This PR was marked stale due to lack of activity and will be closed in 7 days. Commenting or Pushing will instruct the bot to automatically remove the label. This bot runs once per day. |
nit from PR comments
@reyang , @cijothomas , @alanwest |
@notcool11, are you able to fix the build failures? |
@pellared , yep. was failing after pulling latest, had to update the event source per @cijothomas . building in my fork now, should be done shortly |
* Refactor string extensions (#3306) * fixing InMemoryExporter & Metrics bug. new class: MetricSnapshot. new ctor: InMemoryExporter(Func) (#3266) * Exporting tags consistently (#3281) * feat(tracing): deprecate use of B3 propagator class from API package - use Extensions.Propagators package instead (#3289) * Use TagTransformer for ConsoleExporter 💻 (#3311) * Add core tag prefix to OTLP logs project (#3316) * Add Extensions.Propagators to core (#3318) * Changelog update for 1.3.0-rc.1 release prep (#3320) * Adjust changelog to reflect actual date and package (#3327) * Update protos to 0.18.0 (#3321) Co-authored-by: Cijo Thomas <cithomas@microsoft.com> * Propagation in case of remote parent (#3310) * Replace MOQ with InMemoryExporter in ASP.NET Core (#3328) * cleanup CI (#3332) * ConsoleMetricExporter to export all resource attributes (#3334) * Fix EventSource for B3Propagator (#3336) * Update changelog to prepare release (#3337) * Move public api to shipped (#3338) * Post release cleanups (#3340) * Fix NullReferenceException caught by SDK when metric has a tag with a null value (#3325) * Add isRemote check for context propagation (#3329) * Minor test fixes sln additions (#3341) * Update .sln file;Remove docker compose file for net5.0 (#3347) * Remove StackExchangeRedis Instrumenation (#3346) Co-authored-by: Cijo Thomas <cithomas@microsoft.com> * fixed event source in jaegerpropagator after pulling latest Co-authored-by: Piotr Kiełkowicz <pkiekowicz@splunk.com> Co-authored-by: Timothy Mothra <tilee@microsoft.com> Co-authored-by: Alan West <3676547+alanwest@users.noreply.github.com> Co-authored-by: John <cincenko@outlook.com> Co-authored-by: Cijo Thomas <cithomas@microsoft.com> Co-authored-by: Vishwesh Bankwar <vishweshbankwar@users.noreply.github.com> Co-authored-by: Reiley Yang <reyang@microsoft.com> Co-authored-by: Utkarsh Umesan Pillai <utpilla@microsoft.com>
Green in my fork now. |
There are conflicts with |
@pellared , ugh, that's lame. i didn't even change that file. stupid refresh from main now shows 129 files changed when really i just have 5. what a pita. |
is there a better way to refresh my fork than this?? |
|
only files that matter in this PR: do you need me to pull from main again or can you just merge and ignore changes in this PR except the above files?? my guess is this fork will continue to drift and will need to be rebased. |
okay, i'll try that |
Co-authored-by: Robert Pająk <pellared@hotmail.com>
* Added Jaeger Propagator to Opentelemetry.Extensions.Propagators (#3309) * Remove unnecessary bullet in CHANGELOG.md (#3352) Co-authored-by: Cijo Thomas <cithomas@microsoft.com> * Fix OTLP test (#3357) * Show that test is not doing what you might think it does * More asserts the merrier * Show this little test that it has potential * improve test coverage: InMemoryExporter & IDeferredMeterProviderBuilder (#3345) * [SDK] Circular buffer tweaks + cpu pressure test (#3349) * CircularBuffer tweaks and cpu pressure test. * Switch to Volatile.Read. * Perf tweaks. * Remove race check in debug after doing more testing. Co-authored-by: Cijo Thomas <cithomas@microsoft.com> * Fix event name logic + support null categoryname. (#3359) * In-memory Exporter: Buffer log scopes (#3360) * Buffer log scopes when using in-memory exporter. * CHANGELOG update. * Code review. * Tests. * CHANGELOG tweak. * SDK: Forward SetParentProvider to children of CompositeProcessor (#3368) * Examples: Fix ParentProvider not being set on MyFilteringProcessor (#3370) * Fix ParentProvider not being set on MyFilteringProcessor example. * Added XML comments. * Tweak. * Typo. * Logs: Add helper ctors & forceflush on OpenTelemetryLoggerProvider (#3364) * Add helper ctors & forceflush on OpenTelemetryLoggerProvider. * CHANGELOG update. * Unit tests. * Code review. * Code review. * Tweak. * SDK: Nullable annotations for base classes & batch + shims to enable compiler features (#3374) * Nullable annotations and shims for SDK base classes & batch. * Target updates. * Remove System.Collections.Immutable ref. * ApiCompat attribute exclusions. * ASPNETCore instrumentation to populate httpflavor tag (#3372) * improve test coverage: InMemoryExporter SnapshotMetric (#3344) * Fix AspNetCore metrics to use correct value for http.flavor (#3379) * Fix AspNetCore metrics to use correct value for http.flavor * word better * Logs: Add LogRecordData (#3378) * Add LogRecordData and hook up to LogRecord. * CHANGELOG update. * Code review. * Remove SetHttpFlavor from Http instrumentations (#3381) * Asp.Net Core trace instrumentation to populate http schema tag (#3392) * Try asp.net core tests with inproc server (#3394) * Dedupe IsPackable (#3398) * Remove AspNet and AspNet.TelemetryHttpModule instrumentation projects (#3397) * Handle possible exception when initializing the default service name (#3405) * HttpClient: Invoke Enrich when SocketException = HostNotFound (#3407) * Add & use ConfigureResource API. (#3307) Co-authored-by: tyler jago <ty_bone11@hotmail.com> Co-authored-by: Robert Pająk <rpajak@splunk.com> Co-authored-by: Cijo Thomas <cithomas@microsoft.com> Co-authored-by: Timothy Mothra <tilee@microsoft.com> Co-authored-by: Mikel Blanchard <mblanchard@macrosssoftware.com> Co-authored-by: Reiley Yang <reyang@microsoft.com> Co-authored-by: Utkarsh Umesan Pillai <utpilla@microsoft.com> Co-authored-by: Christian Neumüller <christian.neumueller@dynatrace.com>
added jaeger progagator with tests
updated changelog
moved comment to unreleased
Fixes #1881 .
Changes
Added Jaeger Propagator to the new Opentelemetry.Extensions.Propagators project with tests. Been running this code locally as a standalone propagator in production for about six months.
Couple of notes, I've found that URL encoding in headers is not consistent so sometimes the
uber-trace-id
is delimited with a:
colon and sometimes encoded to%3A
. There is also code to handle the shorter 64 traceid vs. the newer 128 bit format.Unit tests should cover all these items. Thanks.
For significant contributions please make sure you have completed the following items:
CHANGELOG.md
updated for non-trivial changes