Remove expensive calculation of gRPC message size #3168
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Aneurysm9
requested review from
jmacd,
MrAlias,
evantorrie,
XSAM,
dashpole,
MadVikingGod,
pellared,
hanyuancheung and
dmathieu
as code owners
Signed-off-by: Anthony J Mirabella <a9@aneurysm9.com>
Aneurysm9
force-pushed
the
fix/grpcSizePerf
branch
from
c9c9290
to
9d79a62
Compare
dashpole
reviewed
Jan 18, 2023
| @@ -14,6 +14,10 @@ This project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.htm | |||
| - `otelmux`: Add new `WithSpanNameFormatter` option to `go.opentelemetry.io/contrib/instrumentation/github.com/gorilla/mux/otelmux` to allow customizing span names. (#3041) | |||
| - Improve documentation for `samplers/jaegerremote` by providing examples of sampling endpoints. (#3147) | |||
|
|
|||
| ### Changed | |||
There was a problem hiding this comment.
should this be Removed instead of changed? Or otherwise marked breaking?
There was a problem hiding this comment.
I'd be fine with moving to Removed but I don't think this counts as breaking as it relates to attributes emitted by telemetry and not package APIs.
bogdandrutu
approved these changes
Jan 18, 2023
|
@Aneurysm9 either not close the issue, or open a separate issue to change to |
|
jpkrohling
approved these changes
Jan 23, 2023
dmathieu
approved these changes
Jan 23, 2023
MrAlias
approved these changes
Jan 23, 2023
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #3168 +/- ##
=====================================
Coverage 69.2% 69.3%
=====================================
Files 147 147
Lines 6893 6885 -8
=====================================
- Hits 4774 4772 -2
+ Misses 2002 1997 -5
+ Partials 117 116 -1
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Anthony J Mirabella a9@aneurysm9.com
See open-telemetry/opentelemetry-collector#6947.
Fixes #3165.