Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

instrgen : Almost complete rewrite of instrgen internals, new way of loading and analyzing packages used by whole go program. utilizing toolexec #4058

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

pdelewski
Copy link
Member

@pdelewski pdelewski commented Jul 11, 2023

This PR brings:

  • utilizes toolexec compiler switch
  • rewrites golang runtime for context propagation
  • it's much faster
  • contains lot of simplifications

@pdelewski pdelewski requested review from a team and MrAlias as code owners July 11, 2023 12:14
@pdelewski pdelewski changed the title Instrgen : new way of loading and analyzing packages used by whole go program. draft instrgen : new way of loading and analyzing packages used by whole go program. Jul 11, 2023
@codecov
Copy link

codecov bot commented Jul 13, 2023

Codecov Report

Merging #4058 (7b9adc1) into main (72a4bcb) will increase coverage by 0.0%.
Report is 1 commits behind head on main.
The diff coverage is 79.4%.

❗ Current head 7b9adc1 differs from pull request most recent head 4aa4632. Consider uploading reports for the commit 4aa4632 to get more accurate results

Impacted file tree graph

@@          Coverage Diff          @@
##            main   #4058   +/-   ##
=====================================
  Coverage   80.8%   80.9%           
=====================================
  Files        148     147    -1     
  Lines      10238   10304   +66     
=====================================
+ Hits        8281    8337   +56     
- Misses      1819    1823    +4     
- Partials     138     144    +6     
Files Coverage Δ
instrgen/driver/main.go 75.2% <79.4%> (+3.6%) ⬆️

@MrAlias
Copy link
Contributor

MrAlias commented Jul 14, 2023

Going to convert this to an actual draft. Please convert back when this is ready for review.

@MrAlias MrAlias marked this pull request as draft July 14, 2023 19:38
@pdelewski pdelewski changed the title draft instrgen : new way of loading and analyzing packages used by whole go program. draft instrgen : Almost complete rewrite of instrgen internals, new way of loading and analyzing packages used by whole go program. utilizing toolexec Jul 21, 2023
@pdelewski pdelewski force-pushed the using-loader branch 3 times, most recently from e8a11a7 to 8b48c7a Compare July 21, 2023 14:16
@pdelewski pdelewski force-pushed the using-loader branch 20 times, most recently from 1158338 to 01a577c Compare August 22, 2023 13:56
@pdelewski pdelewski force-pushed the using-loader branch 14 times, most recently from f702214 to d8b6982 Compare August 22, 2023 20:50
@pdelewski pdelewski marked this pull request as ready for review August 23, 2023 10:35
@pdelewski pdelewski changed the title draft instrgen : Almost complete rewrite of instrgen internals, new way of loading and analyzing packages used by whole go program. utilizing toolexec instrgen : Almost complete rewrite of instrgen internals, new way of loading and analyzing packages used by whole go program. utilizing toolexec Aug 23, 2023
@MrAlias MrAlias added the area: instrgen Related to the instrgen package label Sep 5, 2023
@pdelewski pdelewski force-pushed the using-loader branch 2 times, most recently from 0d7ecef to f39f0a4 Compare September 22, 2023 14:11
pdelewski pushed a commit to SumoLogic-Labs/autotel that referenced this pull request Sep 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: instrgen Related to the instrgen package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants