Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade Exporter to match new API #46

Merged
merged 5 commits into from
Jun 23, 2020
Merged

Upgrade Exporter to match new API #46

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
8e648ac
Upgrade Exporter to match new API
marwan-at-work May 28, 2020
a33c367
Merge branch 'master' into upgradedd
jmacd May 28, 2020
5159c59
Merge branch 'master' into upgradedd
MrAlias Jun 23, 2020
7228d88
Update datadog.go
MrAlias Jun 23, 2020
49f393d
go mod tidy
MrAlias Jun 23, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion exporters/metric/datadog/datadog.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ import (

"github.com/DataDog/datadog-go/statsd"

"go.opentelemetry.io/otel/api/label"
"go.opentelemetry.io/otel/api/metric"
export "go.opentelemetry.io/otel/sdk/export/metric"
"go.opentelemetry.io/otel/sdk/export/metric/aggregator"
Expand Down Expand Up @@ -73,7 +74,7 @@ func (e *Exporter) Export(ctx context.Context, cs export.CheckpointSet) error {
// TODO: Use the Resource() method
agg := r.Aggregator()
name := e.sanitizeMetricName(r.Descriptor().LibraryName(), r.Descriptor().Name())
itr := r.Labels().Iter()
itr := label.NewMergeIterator(r.Labels(), r.Resource().LabelSet())
tags := append([]string{}, e.opts.Tags...)
for itr.Next() {
label := itr.Label()
Expand Down