Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

otelzap: remove dependency on logs sdk #5604

Merged
merged 6 commits into from
May 18, 2024

Conversation

khushijain21
Copy link
Contributor

@khushijain21 khushijain21 commented May 17, 2024

Part of #5191 and #5586

Pre-work #5279

@khushijain21 khushijain21 requested a review from a team May 17, 2024 12:03
@khushijain21 khushijain21 marked this pull request as draft May 17, 2024 12:04
@khushijain21 khushijain21 changed the title otelzap: remove dependency on logs sdk [WIP] otelzap: remove dependency on logs sdk May 17, 2024
Copy link

codecov bot commented May 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.2%. Comparing base (1d0f6fb) to head (06d27ac).

Additional details and impacted files

Impacted file tree graph

@@          Coverage Diff          @@
##            main   #5604   +/-   ##
=====================================
  Coverage   63.2%   63.2%           
=====================================
  Files        194     194           
  Lines      11973   11973           
=====================================
  Hits        7571    7571           
  Misses      4185    4185           
  Partials     217     217           
Files Coverage Δ
bridges/otelzap/core.go 92.9% <100.0%> (ø)

@pellared pellared added the Skip Changelog Allow PR to succeed without requiring an addition to the CHANGELOG label May 17, 2024
@khushijain21 khushijain21 marked this pull request as ready for review May 17, 2024 16:29
@khushijain21 khushijain21 changed the title [WIP] otelzap: remove dependency on logs sdk otelzap: remove dependency on logs sdk May 17, 2024
@MrAlias MrAlias added the bridge: zap Related to the zap bridge label May 17, 2024
Copy link
Member

@pellared pellared left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@MrAlias MrAlias merged commit a481b61 into open-telemetry:main May 18, 2024
23 checks passed
zailic pushed a commit to zailic/opentelemetry-go-contrib that referenced this pull request May 20, 2024
Part of
open-telemetry#5191
and open-telemetry#5586

Pre-work
open-telemetry#5279

---------

Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
@khushijain21 khushijain21 deleted the zapconfig branch May 24, 2024 03:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bridge: zap Related to the zap bridge Skip Changelog Allow PR to succeed without requiring an addition to the CHANGELOG
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants