-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Metric label enrich #1480
Metric label enrich #1480
Conversation
… metric-label-enrich
Codecov Report
@@ Coverage Diff @@
## master #1480 +/- ##
======================================
Coverage 79.0% 79.0%
======================================
Files 128 128
Lines 6685 6703 +18
======================================
+ Hits 5282 5299 +17
- Misses 1148 1149 +1
Partials 255 255
|
@jmacd Could you please take a look when got a chance |
@hstan I haven't forgotten about this, but with the recent re-boot of OTel metrics taking place it's difficult to focus on enrichment. Would you be interested in attending one of the now weekly API/SDK SIG meetings? It's Thursdays on the OTel public calendar. |
@jmacd No worries. Sure I'm more than happy to attend the meeting, could you send me an invitation? Thanks |
I can't figure out how to invite you -- without an e-mail address, and oddly I'm having trouble linking to an event on the OTel public calendar. There is a meeting this week on Thursday at 4pm PST (and every two weeks), which is probably your best bet. |
@jmacd I've got a team event today conflicts with the meeting, I'll try to join next time. btw my email is tanhanshuo(at)gmail.com |
Closing as the metrics signal refactor at the specification level might make this work wasted. We can open again if the specification solidifies and it is determined needed. |
This PR is a rework on #1271 based on @jmacd 's implementation in #1421
It adds an Enricher API that supports attaching baggage attributes as metric labels.
More discussion can be found in the original PR review #1271
and #1271