Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove metric MinMaxSumCount kind aggregation #2423

Conversation

hanyuancheung
Copy link
Member

@hanyuancheung hanyuancheung commented Nov 29, 2021

Resolves #2401

  • remove metric MinMaxSumCount kind aggregation.
  • remove the corresponding OTLP export path.
  • fix unittest and add changelog.

@codecov
Copy link

codecov bot commented Nov 29, 2021

Codecov Report

Merging #2423 (582ad5e) into main (ee60bcc) will decrease coverage by 0.1%.
The diff coverage is 100.0%.

Impacted file tree graph

@@           Coverage Diff           @@
##            main   #2423     +/-   ##
=======================================
- Coverage   75.5%   75.3%   -0.2%     
=======================================
  Files        174     173      -1     
  Lines      12113   11954    -159     
=======================================
- Hits        9147    9011    -136     
+ Misses      2717    2702     -15     
+ Partials     249     241      -8     
Impacted Files Coverage Δ
...otlp/otlpmetric/internal/metrictransform/metric.go 78.1% <ø> (+0.2%) ⬆️
...tlp/otlpmetric/internal/otlpmetrictest/otlptest.go 0.0% <ø> (ø)
exporters/stdout/stdoutmetric/metric.go 81.9% <ø> (+5.6%) ⬆️
sdk/export/metric/aggregation/aggregation.go 0.0% <ø> (ø)
sdk/export/metric/metric.go 0.0% <ø> (ø)
sdk/metric/processor/processortest/test.go 84.1% <ø> (-0.5%) ⬇️
sdk/metric/selector/simple/simple.go 100.0% <100.0%> (ø)
sdk/metric/aggregator/aggregatortest/test.go 81.0% <0.0%> (-2.6%) ⬇️

Copy link
Contributor

@MrAlias MrAlias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This comment needs to be updated to not refer to the removed aggregation type,.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Metrics: Remove the MinMaxSumCount aggregator
4 participants