-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove metric MinMaxSumCount kind aggregation #2423
Merged
MrAlias
merged 8 commits into
open-telemetry:main
from
hanyuancheung:feature/remove_MinMaxSumCount_kind_from_aggregation
Dec 6, 2021
Merged
Remove metric MinMaxSumCount kind aggregation #2423
MrAlias
merged 8 commits into
open-telemetry:main
from
hanyuancheung:feature/remove_MinMaxSumCount_kind_from_aggregation
Dec 6, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hanyuancheung
requested review from
Aneurysm9,
dashpole,
evantorrie,
jmacd,
MadVikingGod,
MrAlias,
paivagustavo,
pellared and
XSAM
as code owners
November 29, 2021 13:18
Codecov Report
@@ Coverage Diff @@
## main #2423 +/- ##
=======================================
- Coverage 75.5% 75.3% -0.2%
=======================================
Files 174 173 -1
Lines 12113 11954 -159
=======================================
- Hits 9147 9011 -136
+ Misses 2717 2702 -15
+ Partials 249 241 -8
|
MrAlias
reviewed
Nov 29, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This comment needs to be updated to not refer to the removed aggregation type,.
jmacd
approved these changes
Dec 1, 2021
MrAlias
approved these changes
Dec 6, 2021
6 tasks
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #2401