-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor the Duplicated code in OTLP Exporter with transform part #2685
Refactor the Duplicated code in OTLP Exporter with transform part #2685
Conversation
Codecov Report
@@ Coverage Diff @@
## main #2685 +/- ##
=======================================
- Coverage 76.7% 76.6% -0.1%
=======================================
Files 181 179 -2
Lines 12175 12059 -116
=======================================
- Hits 9345 9248 -97
+ Misses 2605 2587 -18
+ Partials 225 224 -1
|
e219951
to
d3990bb
Compare
d3990bb
to
cac60a8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems to encompass many more things other than the exporter refactor (there are several go.mod changed, and an unrelated changelog entry added).
How about splitting unrelated changes into separate PRs?
Close. Refactor in other PRs. |
Fix: part of #2641
Follow: #2684
exporter/otlp/otlpmetric(otlptrace)/internal/
intoexporter/otlp/internal/envconfig
exporter/otlp/otlpmetric(otlptrace)/internal/
intoexporter/otlp/internal/transform
exporter/otlp/otlpmetric(otlptrace)/internal/
exporter/otlp/internal/connection