Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor the Duplicated code in OTLP Exporter with transform part #2685

Conversation

hanyuancheung
Copy link
Member

Fix: part of #2641
Follow: #2684

  • Refactor otlpconfig part from exporter/otlp/otlpmetric(otlptrace)/internal/ into exporter/otlp/internal/envconfig
  • Refactor transform part from exporter/otlp/otlpmetric(otlptrace)/internal/ into exporter/otlp/internal/transform
  • Refactor connection part from exporter/otlp/otlpmetric(otlptrace)/internal/ exporter/otlp/internal/connection

@codecov
Copy link

codecov bot commented Mar 19, 2022

Codecov Report

Merging #2685 (0640dd5) into main (70a5446) will decrease coverage by 0.0%.
The diff coverage is 90.0%.

Impacted file tree graph

@@           Coverage Diff           @@
##            main   #2685     +/-   ##
=======================================
- Coverage   76.7%   76.6%   -0.1%     
=======================================
  Files        181     179      -2     
  Lines      12175   12059    -116     
=======================================
- Hits        9345    9248     -97     
+ Misses      2605    2587     -18     
+ Partials     225     224      -1     
Impacted Files Coverage Δ
exporters/otlp/internal/transform/attribute.go 100.0% <ø> (ø)
exporters/otlp/internal/transform/resource.go 100.0% <ø> (ø)
...otlp/otlpmetric/internal/metrictransform/metric.go 78.1% <83.3%> (ø)
...ers/otlp/otlptrace/internal/tracetransform/span.go 96.5% <100.0%> (ø)
attribute/set.go 63.2% <0.0%> (+1.3%) ⬆️
sdk/trace/batch_span_processor.go 82.1% <0.0%> (+1.8%) ⬆️
attribute/iterator.go 84.0% <0.0%> (+2.8%) ⬆️
attribute/kv.go 91.6% <0.0%> (+41.6%) ⬆️

@hanyuancheung hanyuancheung force-pushed the refactor-duplicated-code-otlp-exporter-transform branch 2 times, most recently from e219951 to d3990bb Compare March 19, 2022 22:56
@hanyuancheung hanyuancheung force-pushed the refactor-duplicated-code-otlp-exporter-transform branch from d3990bb to cac60a8 Compare March 19, 2022 23:05
Copy link
Member

@dmathieu dmathieu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems to encompass many more things other than the exporter refactor (there are several go.mod changed, and an unrelated changelog entry added).
How about splitting unrelated changes into separate PRs?

@hanyuancheung
Copy link
Member Author

Close. Refactor in other PRs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants