-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New stdoutmetric encoder with ignore timestamp #3828
Conversation
Signed-off-by: Peter Liu <lpfvip2008@gmail.com>
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #3828 +/- ##
=======================================
+ Coverage 81.6% 81.7% +0.1%
=======================================
Files 169 169
Lines 12489 12570 +81
=======================================
+ Hits 10201 10281 +80
- Misses 2073 2074 +1
Partials 215 215
|
The approach showcased in #3529 added an option instead of a dedicated encoder. That approach would apply to all encoders instead of a single one. Should that approach be taken instead? |
I apologize for not noticing the "POC" pull request. After reviewing the code structure, I believe it is more organized than mine. I will refactor my code to avoid using a dedicated encoder. |
Signed-off-by: Peter Liu <lpfvip2008@gmail.com>
Signed-off-by: Peter Liu <lpfvip2008@gmail.com>
Signed-off-by: Peter Liu <lpfvip2008@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Over all looks good. The testing needs some coverage added to it.
Please be sure to add a changelog entry. |
Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
Signed-off-by: Peter Liu <lpfvip2008@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have forgotten to click "submit review" a few hours ago 😆
Resolve: #3223